Skip to content

8305950: Have -XshowSettings option display tzdata version #13865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

coffeys
Copy link
Contributor

@coffeys coffeys commented May 8, 2023

minor enhancement to have -XshowSettings launcher option display the version of tzdata installed in the JDK

example output of the new tzdata info :

....
Locale settings:
    default locale = English
    default display locale = English
    default format locale = English
    tzdata version = 2023c
    available locales = , af, af_NA, af_ZA, af_ZA_#Latn, agq, agq_CM, agq_CM_#Latn,
    ......

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305950: Have -XshowSettings option display tzdata version

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13865/head:pull/13865
$ git checkout pull/13865

Update a local copy of the PR:
$ git checkout pull/13865
$ git pull https://git.openjdk.org/jdk.git pull/13865/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13865

View PR using the GUI difftool:
$ git pr show -t 13865

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13865.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 8, 2023

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8305950 8305950: Have -XshowSettings option display tzdata version May 8, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label May 8, 2023
@openjdk
Copy link

openjdk bot commented May 8, 2023

@coffeys The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels May 8, 2023
@mlbridge
Copy link

mlbridge bot commented May 8, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 8, 2023

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305950: Have -XshowSettings option display tzdata version

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bb3e44d: 8307603: [AIX] Broken build after JDK-8307301

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 8, 2023
@coffeys
Copy link
Contributor Author

coffeys commented May 9, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 9, 2023

Going to push as commit 07f55c5.
Since your change was applied there have been 15 commits pushed to the master branch:

  • d9052b9: 8307130: Open source few Swing JMenu tests
  • 5e1fe43: 8299229: [JVMCI] add support for UseZGC
  • 14df5c1: 8307165: java/awt/dnd/NoFormatsDropTest/NoFormatsDropTest.java timed out
  • 7f6358a: 8291555: Implement alternative fast-locking scheme
  • 4116b10: 8306461: ObjectInputStream::readObject() should handle negative array sizes without throwing NegativeArraySizeExceptions
  • 93ee19f: 8305486: Add split() variants that keep the delimiters to String and j.u.r.Pattern
  • ad90fb6: 8293786: HttpClient will not send more than 64 kb of data from the 2nd request in http2
  • 5a259d8: 8303153: Native interpreter frame missing mirror
  • 4b02956: 8054022: HttpURLConnection timeouts with Expect: 100-Continue and no chunking
  • 9f34e4f: 8304434: [AIX] Update minimum xlclang version
  • ... and 5 more: https://git.openjdk.org/jdk/compare/5c7ede94ae59b46c12d40a38bf5b7e15319cc7e2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 9, 2023
@openjdk openjdk bot closed this May 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

@coffeys Pushed as commit 07f55c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants