8297657: name demangling intermittently fails

[fbredber]

Fixes an intermittent name demangling problem (due to the uninitialized AbstractDecoder::_decoder_status field).
The problem affected hs-err stack traces on macosx-aarch64 and macosx-amd64.

I've done manual testing to verify the problem and the solution.
Also run tier1-5 after the fix without seeing any new problems.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297657: name demangling intermittently fails

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13883/head:pull/13883
$ git checkout pull/13883

Update a local copy of the PR:
$ git checkout pull/13883
$ git pull https://git.openjdk.org/jdk.git pull/13883/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13883

View PR using the GUI difftool:
$ git pr show -t 13883

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13883.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fbredber! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fbredber The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (890046bf)
• 00: Full (3605d84f)

[stefank]

It looks like this bug could have been prevented if AbstractDecoder had a constructor that initialized _decoder_status with the value passed down from the sub-class. Maybe this RFE could be an opportunity to improve this?

[openjdk]

@fbredber This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297657: name demangling intermittently fails

Reviewed-by: stefank, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 234 new commits pushed to the master branch:

• 0cbfbc4: 8307813: [JVMCI] Export markWord::lock_mask_in_place to JVMCI compilers.
• ba9714d: 8307610: Linker::nativeLinker should not be restricted (mainline)
• ecc1d85: 8307869: Remove unnecessary log statements from arm32 fastlocking code
• 08fa269: 8307349: Support xlc17 clang toolchain on AIX
• 8ac7186: 8305416: runtime/Thread/TestAlwaysPreTouchStacks.java failed with "Did not find expected NMT output"
• 984fbbb: 8307810: Consistently use LockingMode instead of UseHeavyMonitors
• 39f4e4d: 8307758: RISC-V: Improve bit test code introduced by JDK-8291555
• 3cb606e: 8306965: osThread allocation failures should not abort the VM
• 4795c39: 8281103: Give example for Locale that is English and follows the ISO standards
• 958d4a7: 8307563: make most fields final in JavacTrees
• ... and 224 more: https://git.openjdk.org/jdk/compare/35e7bc21d3c1b38e2268924b20ae4b149b4f8cd8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @coleenp) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[coleenp]

Yes this looks good. I didn't see the not_available initialization so passing the initial status is right.

[fbredber]

Thanks for the review and comments. Can any of you give me a helping hand (and sponsor) the integration?

[fbredber]

/integrate

[openjdk]

@fbredber
Your change (at version 890046b) is now ready to be sponsored by a Committer.

[coleenp]

/sponsor

[openjdk]

Going to push as commit 2bf7ac5.
Since your change was applied there have been 235 commits pushed to the master branch:

• d20034b: 8307058: Implementation of Generational ZGC
• 0cbfbc4: 8307813: [JVMCI] Export markWord::lock_mask_in_place to JVMCI compilers.
• ba9714d: 8307610: Linker::nativeLinker should not be restricted (mainline)
• ecc1d85: 8307869: Remove unnecessary log statements from arm32 fastlocking code
• 08fa269: 8307349: Support xlc17 clang toolchain on AIX
• 8ac7186: 8305416: runtime/Thread/TestAlwaysPreTouchStacks.java failed with "Did not find expected NMT output"
• 984fbbb: 8307810: Consistently use LockingMode instead of UseHeavyMonitors
• 39f4e4d: 8307758: RISC-V: Improve bit test code introduced by JDK-8291555
• 3cb606e: 8306965: osThread allocation failures should not abort the VM
• 4795c39: 8281103: Give example for Locale that is English and follows the ISO standards
• ... and 225 more: https://git.openjdk.org/jdk/compare/35e7bc21d3c1b38e2268924b20ae4b149b4f8cd8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp @fbredber Pushed as commit 2bf7ac5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.