8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712

[afshin-zafari]

• The finalize() method is replaced with cleanup().
• A new constructor is added to register the cleanup method.
• A static Cleaner is defined to have only one cleaner thread for all the 15000 instances. Otherwise, we get an OutOfMemoryException on cleaner thread creation.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13886/head:pull/13886
$ git checkout pull/13886

Update a local copy of the PR:
$ git checkout pull/13886
$ git pull https://git.openjdk.org/jdk.git pull/13886/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13886

View PR using the GUI difftool:
$ git pr show -t 13886

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13886.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back afshin-zafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@afshin-zafari The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6b3d43ba)

[coleenp]

I think this looks good, and still tests what the original test failure was. Unless the bug was with the _return_register_finalizer bytecode, but I don't think that's the case.

[openjdk]

@afshin-zafari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712

Reviewed-by: coleenp, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 93 new commits pushed to the master branch:

• f7bbbc6: 8307808: G1: Remove partial object-count report after gc
• 13a3fce: 8307961: java/foreign/enablenativeaccess/TestEnableNativeAccess.java fails with ShouldNotReachHere
• f09a0f5: 8307806: Rename Atomic::fetch_and_add and friends
• b6bcbc0: 8305770: os::Linux::available_memory() should refer MemAvailable in /proc/meminfo
• e1e758a: 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests
• 1ce1611: 8307518: Remove G1 workaround in jstat about zero sized generation sizes
• e32de7e: 8306667: RISC-V: Fix storeImmN0 matching rule by using zr register
• f3bd031: 8307891: ProblemList gtest/NMTGtest.java subtests on aix
• 5f1f946: 8307520: set minimum supported CPU architecture to Power8 on AIX
• ccb4dd6: 8307969: [zgc] Missing includes in gc/z/zTracer.cpp
• ... and 83 more: https://git.openjdk.org/jdk/compare/5c7ede94ae59b46c12d40a38bf5b7e15319cc7e2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

The fix looks good to me. Not sure though how much sense that test still makes after the AOT removal but I guess keeping it does not hurt.

[afshin-zafari]

Thank you @coleenp and @TobiHartmann for your comments.
/integrate

[openjdk]

Going to push as commit 39dc40f.
Since your change was applied there have been 93 commits pushed to the master branch:

• f7bbbc6: 8307808: G1: Remove partial object-count report after gc
• 13a3fce: 8307961: java/foreign/enablenativeaccess/TestEnableNativeAccess.java fails with ShouldNotReachHere
• f09a0f5: 8307806: Rename Atomic::fetch_and_add and friends
• b6bcbc0: 8305770: os::Linux::available_memory() should refer MemAvailable in /proc/meminfo
• e1e758a: 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests
• 1ce1611: 8307518: Remove G1 workaround in jstat about zero sized generation sizes
• e32de7e: 8306667: RISC-V: Fix storeImmN0 matching rule by using zr register
• f3bd031: 8307891: ProblemList gtest/NMTGtest.java subtests on aix
• 5f1f946: 8307520: set minimum supported CPU architecture to Power8 on AIX
• ccb4dd6: 8307969: [zgc] Missing includes in gc/z/zTracer.cpp
• ... and 83 more: https://git.openjdk.org/jdk/compare/5c7ede94ae59b46c12d40a38bf5b7e15319cc7e2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@afshin-zafari Pushed as commit 39dc40f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.