8306930: Incorrect assert in BitMap::count_one_bits

[fbredber]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8306930: Incorrect assert in BitMap::count_one_bits

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13887/head:pull/13887
$ git checkout pull/13887

Update a local copy of the PR:
$ git checkout pull/13887
$ git pull https://git.openjdk.org/jdk.git pull/13887/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13887

View PR using the GUI difftool:
$ git pr show -t 13887

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13887.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fbredber! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fbredber The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a7f00b06)

[stefank]

Looks good.

It's a bit odd that these counting functions return an idx_t, which I think should be used for indices and not counts, IIUC.

[openjdk]

@fbredber This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306930: Incorrect assert in BitMap::count_one_bits

Reviewed-by: stefank, tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 206 new commits pushed to the master branch:

• 4b4c80b: 8307351: (CmpI/L(AndI/L reg1 reg2)) on x86 can be optimized
• d3e6d04: 8307651: RISC-V: stringL_indexof_char instruction has wrong format string
• 2be1f10: 8307399: get rid of compatibility ThreadStart/ThreadEnd events for virtual threads
• f5a6b7f: 8306027: Clarify JVMTI heap functions spec about virtual thread stack.
• a1c3adb: 8307370: Add tier1 testing with thread factory in CI
• 356667f: 8307466: java.time.Instant calculation bug in until and between methods
• 723582c: 8306881: Update FreeType to 2.13.0
• 9829424: 8307128: Open source some drag and drop tests 4
• 7f05f6f: 8307307: Improve ProcessTools.java to don't try to run Virtual wrapper for incompatible processes
• dde557e: 8304148: Remapping a class with Invokedynamic constant loses static bootstrap arguments
• ... and 196 more: https://git.openjdk.org/jdk/compare/35e7bc21d3c1b38e2268924b20ae4b149b4f8cd8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @tschatzl, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[kimbarrett]

Looks good.

[kimbarrett]

It's a bit odd that these counting functions return an idx_t, which I think should be used for indices and not counts, IIUC.

Agreed. idx_t is overused in various ways. I've got some cleanups somewhat in progress for that.

[fbredber]

Thanks for the review guys. Can any of you give me a helping hand (and sponsor) the integration?

[fbredber]

/integrate

[openjdk]

@fbredber
Your change (at version a7f00b0) is now ready to be sponsored by a Committer.

[stefank]

/sponsor

[openjdk]

Going to push as commit d993432.
Since your change was applied there have been 206 commits pushed to the master branch:

• 4b4c80b: 8307351: (CmpI/L(AndI/L reg1 reg2)) on x86 can be optimized
• d3e6d04: 8307651: RISC-V: stringL_indexof_char instruction has wrong format string
• 2be1f10: 8307399: get rid of compatibility ThreadStart/ThreadEnd events for virtual threads
• f5a6b7f: 8306027: Clarify JVMTI heap functions spec about virtual thread stack.
• a1c3adb: 8307370: Add tier1 testing with thread factory in CI
• 356667f: 8307466: java.time.Instant calculation bug in until and between methods
• 723582c: 8306881: Update FreeType to 2.13.0
• 9829424: 8307128: Open source some drag and drop tests 4
• 7f05f6f: 8307307: Improve ProcessTools.java to don't try to run Virtual wrapper for incompatible processes
• dde557e: 8304148: Remapping a class with Invokedynamic constant loses static bootstrap arguments
• ... and 196 more: https://git.openjdk.org/jdk/compare/35e7bc21d3c1b38e2268924b20ae4b149b4f8cd8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@stefank @fbredber Pushed as commit d993432.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.