Skip to content

8281103: Give example for Locale that is English and follows the ISO standards #13893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented May 9, 2023

Please review this PR which adds an example snippet to java.time.temporal.WeekFields.of(Locale locale)

The snippet demonstrates how to create a Locale that has English Locale qualities with an ISO-8601 first day of the week.

This snippet was added as there was a desire for an English/ISO-8601 Locale constant to be added, but the existing methods in the JDK are better suited for accomplishing this.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8307546 to be approved

Issues

  • JDK-8281103: Give example for Locale that is English and follows the ISO standards
  • JDK-8307546: Give example for Locale that is English and follows the ISO standards (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13893/head:pull/13893
$ git checkout pull/13893

Update a local copy of the PR:
$ git checkout pull/13893
$ git pull https://git.openjdk.org/jdk.git pull/13893/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13893

View PR using the GUI difftool:
$ git pr show -t 13893

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13893.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels May 9, 2023
@mlbridge
Copy link

mlbridge bot commented May 9, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 9, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281103: Give example for Locale that is English and follows the ISO standards

Reviewed-by: rriggs, lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 172 new commits pushed to the master branch:

  • a1c3adb: 8307370: Add tier1 testing with thread factory in CI
  • 356667f: 8307466: java.time.Instant calculation bug in until and between methods
  • 723582c: 8306881: Update FreeType to 2.13.0
  • 9829424: 8307128: Open source some drag and drop tests 4
  • 7f05f6f: 8307307: Improve ProcessTools.java to don't try to run Virtual wrapper for incompatible processes
  • dde557e: 8304148: Remapping a class with Invokedynamic constant loses static bootstrap arguments
  • 82bcee7: 8159337: Introduce a method in Locale class to return the language tags as per RFC 5646 convention
  • 3aff5ea: 8307486: ProcessTools.java should wait until vthread is completed before checking exceptions
  • 44fa12e: 8303830: update for deprecated sprintf for jdk.accessibility
  • fdbfc8a: 8133773: clarify specification of Spliterator.tryAdvance
  • ... and 162 more: https://git.openjdk.org/jdk/compare/b827ce8334c568d72990985ff6077db8334e2754...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2023
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels May 9, 2023
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels May 9, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2023

Going to push as commit 4795c39.
Since your change was applied there have been 195 commits pushed to the master branch:

  • 958d4a7: 8307563: make most fields final in JavacTrees
  • f250ab2: 8307377: Remove use of tagName from TagletWriterImpl.linkSeeReferenceOutput
  • cc9f7ad: 8307765: DynamicArchiveHeader contents are missing in CDS mapfile
  • edc4adb: 8307860: [BACKOUT] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
  • df90df2: 8307857: validate-source fails after JDK-8306758
  • 2688364: 8306758: com/sun/jdi/ConnectedVMs.java fails with "Non-zero debuggee exitValue: 143"
  • 1964954: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
  • 9af1787: 8307244: Remove redundant class RMIIIOPServerImpl
  • 8a95020: 8151531: Add notes to BaseStream.spliterator/iterator docs regarding them being escape hatches
  • 0198afc: 8305748: Clarify reentrant behavior of close() in FileInputStream, FileOutputStream, and RandomAccessFile
  • ... and 185 more: https://git.openjdk.org/jdk/compare/b827ce8334c568d72990985ff6077db8334e2754...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2023
@openjdk openjdk bot closed this May 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2023
@openjdk
Copy link

openjdk bot commented May 10, 2023

@justin-curtis-lu Pushed as commit 4795c39.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants