Skip to content

8307808: G1: Remove partial object-count report after gc #13897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8307808: G1: Remove partial object-count report after gc #13897

wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented May 10, 2023 •
edited by openjdk bot
Loading

Simple removing object-count event in the case of incomplete-marking.

Test: hotspot_gc

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307808: G1: Remove partial object-count report after gc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13897/head:pull/13897
$ git checkout pull/13897

Update a local copy of the PR:
$ git checkout pull/13897
$ git pull https://git.openjdk.org/jdk.git pull/13897/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13897

View PR using the GUI difftool:
$ git pr show -t 13897

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13897.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8307808 8307808: G1: Remove partial object-count report after gc May 10, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2023
@openjdk
Copy link

openjdk bot commented May 10, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label May 10, 2023
@mlbridge
Copy link

mlbridge bot commented May 10, 2023

Webrevs

tschatzl
tschatzl approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Feel free to consider doing the suggested optimization in a separate cr.

src/hotspot/share/gc/g1/g1ConcurrentMark.cpp

bool do_object_b(oop obj) {
return obj != nullptr &&
(!_g1h->is_in_reserved(obj) || !_g1h->is_obj_dead(obj));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the first clause can be removed (or asserted); the (parallel-)objectiterator for g1 always returns true for that as it only ever iterates over the heap regions.
Also the != nullptr is imo removable for the same reason. We are walking the heap linearly, so I do not see how that value could be null.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think so; will do it in another PR.

@openjdk
Copy link

openjdk bot commented May 10, 2023 •
edited
Loading

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307808: G1: Remove partial object-count report after gc

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • cc39689: 8300245: Replace NULL with nullptr in share/jfr/
  • 4251b56: 8306843: JVMTI tag map extremely slow after JDK-8292741
  • ab34cb9: 8305082: Remove finalize() from test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java
  • 0da48f1: 8307732: build-test-lib is broken
  • 4aa65cb: 8285932: Implementation of JEP 430 String Templates (Preview)
  • da2c930: 8302845: Replace finalizer usage in JNDI DNS provider with Cleaner

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 10, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented May 12, 2023

Going to push as commit f7bbbc6.
Since your change was applied there have been 52 commits pushed to the master branch:

  • 13a3fce: 8307961: java/foreign/enablenativeaccess/TestEnableNativeAccess.java fails with ShouldNotReachHere
  • f09a0f5: 8307806: Rename Atomic::fetch_and_add and friends
  • b6bcbc0: 8305770: os::Linux::available_memory() should refer MemAvailable in /proc/meminfo
  • e1e758a: 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests
  • 1ce1611: 8307518: Remove G1 workaround in jstat about zero sized generation sizes
  • e32de7e: 8306667: RISC-V: Fix storeImmN0 matching rule by using zr register
  • f3bd031: 8307891: ProblemList gtest/NMTGtest.java subtests on aix
  • 5f1f946: 8307520: set minimum supported CPU architecture to Power8 on AIX
  • ccb4dd6: 8307969: [zgc] Missing includes in gc/z/zTracer.cpp
  • 73491fa: 8306996: Open source Swing MenuItem related tests
  • ... and 42 more: https://git.openjdk.org/jdk/compare/540c706bbcbb809ae1304aac4f2a16a5e83cb458...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 12, 2023
@openjdk openjdk bot closed this May 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 12, 2023
@openjdk
Copy link

openjdk bot commented May 12, 2023

@albertnetymk Pushed as commit f7bbbc6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the g1-remark-obj-count branch May 12, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschatzl tschatzl tschatzl approved these changes

@walulyai walulyai walulyai approved these changes

Assignees
No one assigned
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertnetymk @tschatzl @walulyai