Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307850: update for deprecated sprintf for jdk.jdi #13913

Closed
wants to merge 1 commit into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented May 10, 2023

Hi,

May I have this update reviewed?

The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of security concerns. The issue was addressed in JDK-8296812 for building failure, and JDK-8299378/JDK-8299635/JDK-8301132 for testing issues . This is a break-down update for sprintf uses in the jdk.jdi module.

Thanks,
Xuelei


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307850: update for deprecated sprintf for jdk.jdi

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13913/head:pull/13913
$ git checkout pull/13913

Update a local copy of the PR:
$ git checkout pull/13913
$ git pull https://git.openjdk.org/jdk.git pull/13913/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13913

View PR using the GUI difftool:
$ git pr show -t 13913

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13913.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2023

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 10, 2023

@XueleiFan The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label May 10, 2023
@XueleiFan XueleiFan marked this pull request as ready for review May 11, 2023 02:26
@openjdk openjdk bot added the rfr Pull request is ready for review label May 11, 2023
@mlbridge
Copy link

mlbridge bot commented May 11, 2023

Webrevs

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Please make sure run the com/sun/jdi and nsk/jdi tests on linux and windows.

@openjdk
Copy link

openjdk bot commented May 11, 2023

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307850: update for deprecated sprintf for jdk.jdi

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 39f4e4d: 8307758: RISC-V: Improve bit test code introduced by JDK-8291555
  • 3cb606e: 8306965: osThread allocation failures should not abort the VM
  • 4795c39: 8281103: Give example for Locale that is English and follows the ISO standards
  • 958d4a7: 8307563: make most fields final in JavacTrees
  • f250ab2: 8307377: Remove use of tagName from TagletWriterImpl.linkSeeReferenceOutput
  • cc9f7ad: 8307765: DynamicArchiveHeader contents are missing in CDS mapfile
  • edc4adb: 8307860: [BACKOUT] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
  • df90df2: 8307857: validate-source fails after JDK-8306758
  • 2688364: 8306758: com/sun/jdi/ConnectedVMs.java fails with "Non-zero debuggee exitValue: 143"
  • 1964954: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 11, 2023
@XueleiFan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 11, 2023

Going to push as commit cbecf42.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 7fcb0fd: 8307139: Fix signed integer overflow in compiler code, part 1
  • 5d6cce0: 8307298: JFR: Ensure jdk.jfr.internal.TypeLibrary is initialized only once
  • 51b8f3c: 8306034: add support of virtual threads to JVMTI StopThread
  • 489658d: 8307885: com/sun/jdi/ConnectedVMs.java fails with "Invalid debuggee exitValue: 0"
  • 9ad38cb: 8307626: java/net/httpclient/FlowAdapter* tests should close the HttpClient instances
  • 2bf7ac5: 8297657: name demangling intermittently fails
  • d20034b: 8307058: Implementation of Generational ZGC
  • 0cbfbc4: 8307813: [JVMCI] Export markWord::lock_mask_in_place to JVMCI compilers.
  • ba9714d: 8307610: Linker::nativeLinker should not be restricted (mainline)
  • ecc1d85: 8307869: Remove unnecessary log statements from arm32 fastlocking code
  • ... and 13 more: https://git.openjdk.org/jdk/compare/9af1787ebe842bcfbf4a03a9deefe19bbd1ee87d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 11, 2023
@openjdk openjdk bot closed this May 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

@XueleiFan Pushed as commit cbecf42.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8307850 branch May 11, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants