Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8307954: Update string template regression tests to be robust on release updates #13936

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented May 11, 2023

Change the string template diagnostic tests to use the preferred ${jdk.version} idiom rather than hard-coding a particular release value.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307954: Update string template regression tests to be robust on release updates

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13936/head:pull/13936
$ git checkout pull/13936

Update a local copy of the PR:
$ git checkout pull/13936
$ git pull https://git.openjdk.org/jdk.git pull/13936/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13936

View PR using the GUI difftool:
$ git pr show -t 13936

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13936.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2023

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label May 11, 2023
Copy link
Member

@JimLaskey JimLaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented May 11, 2023

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307954: Update string template regression tests to be robust on release updates

Reviewed-by: jlaskey

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 1535863: 8307848: update for deprecated sprintf for jdk.attach
  • cbecf42: 8307850: update for deprecated sprintf for jdk.jdi
  • 7fcb0fd: 8307139: Fix signed integer overflow in compiler code, part 1
  • 5d6cce0: 8307298: JFR: Ensure jdk.jfr.internal.TypeLibrary is initialized only once
  • 51b8f3c: 8306034: add support of virtual threads to JVMTI StopThread
  • 489658d: 8307885: com/sun/jdi/ConnectedVMs.java fails with "Invalid debuggee exitValue: 0"
  • 9ad38cb: 8307626: java/net/httpclient/FlowAdapter* tests should close the HttpClient instances
  • 2bf7ac5: 8297657: name demangling intermittently fails
  • d20034b: 8307058: Implementation of Generational ZGC
  • 0cbfbc4: 8307813: [JVMCI] Export markWord::lock_mask_in_place to JVMCI compilers.
  • ... and 5 more: https://git.openjdk.org/jdk/compare/39f4e4d3c3450ed8fe314e2abde6a6cecd5fa0a5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 11, 2023
@jddarcy
Copy link
Member Author

jddarcy commented May 11, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 11, 2023

Going to push as commit 29b8242.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 4f355c3: 8307653: Adjust delay time and gc log argument in TestAbortOnVMOperationTimeout
  • 1535863: 8307848: update for deprecated sprintf for jdk.attach
  • cbecf42: 8307850: update for deprecated sprintf for jdk.jdi
  • 7fcb0fd: 8307139: Fix signed integer overflow in compiler code, part 1
  • 5d6cce0: 8307298: JFR: Ensure jdk.jfr.internal.TypeLibrary is initialized only once
  • 51b8f3c: 8306034: add support of virtual threads to JVMTI StopThread
  • 489658d: 8307885: com/sun/jdi/ConnectedVMs.java fails with "Invalid debuggee exitValue: 0"
  • 9ad38cb: 8307626: java/net/httpclient/FlowAdapter* tests should close the HttpClient instances
  • 2bf7ac5: 8297657: name demangling intermittently fails
  • d20034b: 8307058: Implementation of Generational ZGC
  • ... and 6 more: https://git.openjdk.org/jdk/compare/39f4e4d3c3450ed8fe314e2abde6a6cecd5fa0a5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 11, 2023
@openjdk openjdk bot closed this May 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

@jddarcy Pushed as commit 29b8242.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented May 11, 2023

Webrevs

@jddarcy jddarcy deleted the JDK-8307954 branch June 10, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants