Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308010: X509Key and PKCS8Key allows garbage bytes at the end #13958

Closed
wants to merge 2 commits into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented May 12, 2023

When parsing a byte array to a private or public key, it's now converted to a ByteArrayInputStream and the parser does not report an error if there are extra bytes at the end.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308010: X509Key and PKCS8Key allows garbage bytes at the end

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13958/head:pull/13958
$ git checkout pull/13958

Update a local copy of the PR:
$ git checkout pull/13958
$ git pull https://git.openjdk.org/jdk.git pull/13958/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13958

View PR using the GUI difftool:
$ git pr show -t 13958

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13958.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2023

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 12, 2023
@openjdk
Copy link

openjdk bot commented May 12, 2023

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 12, 2023
@mlbridge
Copy link

mlbridge bot commented May 12, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 18, 2023

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308010: X509Key and PKCS8Key allows garbage bytes at the end

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 198 new commits pushed to the master branch:

  • d3feedf: 8308192: Error in parsing replay file when staticfield is an array of single dimension
  • 02dc95e: 8308370: Fix build failures related to the java.awt.Robot documentation
  • 21aa057: 8307779: Relax the java.awt.Robot specification
  • 42ecc8a: 8308245: Add -proc:full to describe current default annotation processing policy
  • bb24c36: 8279993: Assert that a shared class is not loaded more than once
  • 1b154e4: 8307083: Open source some drag and drop tests 3
  • cc5c9b5: 8305787: Wrong debugging information printed with TraceOptoOutput
  • 808dc1b: 8308350: Increase buffer size for jspawnhelper arguments
  • a58e0ca: 8308347: [s390x] build broken after JDK-8304913
  • bfc3ccd: 8308283: Build failure with GCC12 & GCC13
  • ... and 188 more: https://git.openjdk.org/jdk/compare/b5922c3b869e7dab97ffca6d0bc7927369630f03...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 18, 2023
@wangweij
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 18, 2023

Going to push as commit 148df53.
Since your change was applied there have been 198 commits pushed to the master branch:

  • d3feedf: 8308192: Error in parsing replay file when staticfield is an array of single dimension
  • 02dc95e: 8308370: Fix build failures related to the java.awt.Robot documentation
  • 21aa057: 8307779: Relax the java.awt.Robot specification
  • 42ecc8a: 8308245: Add -proc:full to describe current default annotation processing policy
  • bb24c36: 8279993: Assert that a shared class is not loaded more than once
  • 1b154e4: 8307083: Open source some drag and drop tests 3
  • cc5c9b5: 8305787: Wrong debugging information printed with TraceOptoOutput
  • 808dc1b: 8308350: Increase buffer size for jspawnhelper arguments
  • a58e0ca: 8308347: [s390x] build broken after JDK-8304913
  • bfc3ccd: 8308283: Build failure with GCC12 & GCC13
  • ... and 188 more: https://git.openjdk.org/jdk/compare/b5922c3b869e7dab97ffca6d0bc7927369630f03...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 18, 2023
@openjdk openjdk bot closed this May 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 18, 2023
@openjdk
Copy link

openjdk bot commented May 18, 2023

@wangweij Pushed as commit 148df53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8308010 branch May 23, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants