Skip to content

8307976: (fs) Files.createDirectories(dir) returns dir::toAbsolutePath instead of dir#13959

Closed
bplb wants to merge 7 commits intoopenjdk:masterfrom
bplb:Files-createDirectories-8307976
Closed

8307976: (fs) Files.createDirectories(dir) returns dir::toAbsolutePath instead of dir#13959
bplb wants to merge 7 commits intoopenjdk:masterfrom
bplb:Files-createDirectories-8307976

Conversation

@bplb
Copy link
Member

@bplb bplb commented May 12, 2023

Return dir, not dir::toAbsolutePath.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307976: (fs) Files.createDirectories(dir) returns dir::toAbsolutePath instead of dir

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13959/head:pull/13959
$ git checkout pull/13959

Update a local copy of the PR:
$ git checkout pull/13959
$ git pull https://git.openjdk.org/jdk.git pull/13959/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13959

View PR using the GUI difftool:
$ git pr show -t 13959

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13959.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2023

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 12, 2023
@openjdk
Copy link

openjdk bot commented May 12, 2023

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label May 12, 2023
@mlbridge
Copy link

mlbridge bot commented May 12, 2023

Webrevs

@bplb
Copy link
Member Author

bplb commented May 12, 2023

The modified test fails without but passes with the proposed source change.

@openjdk
Copy link

openjdk bot commented May 17, 2023

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307976: (fs) Files.createDirectories(dir) returns dir::toAbsolutePath instead of dir

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

  • e34ecc9: 8296469: Instrument VMError::report with reentrant iteration step for register and stack printing
  • 5a92aae: 8308156: VerifyCACerts.java misses blank in error output
  • 2f1c654: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'
  • d3e5065: 8306460: Clear JVM_ACC_QUEUED flag on methods when dumping dynamic CDS archive
  • 563152f: 8308223: failure handler missed jcmd.vm.info command
  • cb8b8cd: 8307458: Add periodic heap usage JFR events
  • f9a785e: 8307547: Support variant collations
  • 4e92991: 8300794: Use @snippet in java.util:i18n
  • 64d5157: 8306467: Fix nsk/jdb/kill/kill001 to work with new JVMTI StopThread support for virtual threads.
  • 488330d: 8307533: Use atomic bitset functions for metadata flags
  • ... and 45 more: https://git.openjdk.org/jdk/compare/6ebea8973feb08a7443d8d86ff52f453dc4aec43...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 17, 2023
@bplb
Copy link
Member Author

bplb commented May 17, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 17, 2023

Going to push as commit 6d4782b.
Since your change was applied there have been 62 commits pushed to the master branch:

  • f57c783: 8308239: Tighten up accessibility of nested classes in java.lang.invoke
  • 64f6681: 8308246: PPC64le build broken after JDK-8304913
  • 5763be7: 8307326: Package jdk.internal.classfile.java.lang.constant become obsolete
  • c7951cf: 8306304: Fix xlc17 clang warnings in ppc and aix code
  • 285c833: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
  • 1a6f981: 8308185: Update Http2TestServerConnection to use SSLSocket.startHandshake()
  • b300e73: 8308088: Improve class check in CollectedHeap::is_oop
  • e34ecc9: 8296469: Instrument VMError::report with reentrant iteration step for register and stack printing
  • 5a92aae: 8308156: VerifyCACerts.java misses blank in error output
  • 2f1c654: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'
  • ... and 52 more: https://git.openjdk.org/jdk/compare/6ebea8973feb08a7443d8d86ff52f453dc4aec43...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 17, 2023
@openjdk openjdk bot closed this May 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2023
@openjdk
Copy link

openjdk bot commented May 17, 2023

@bplb Pushed as commit 6d4782b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the Files-createDirectories-8307976 branch May 18, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated nio nio-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants