8307976: (fs) Files.createDirectories(dir) returns dir::toAbsolutePath instead of dir#13959
8307976: (fs) Files.createDirectories(dir) returns dir::toAbsolutePath instead of dir#13959bplb wants to merge 7 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back bpb! A progress list of the required criteria for merging this PR into |
Webrevs
|
|
The modified test fails without but passes with the proposed source change. |
|
@bplb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 55 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 6d4782b.
Your commit was automatically rebased without conflicts. |
Return
dir, notdir::toAbsolutePath.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13959/head:pull/13959$ git checkout pull/13959Update a local copy of the PR:
$ git checkout pull/13959$ git pull https://git.openjdk.org/jdk.git pull/13959/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13959View PR using the GUI difftool:
$ git pr show -t 13959Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13959.diff
Webrev
Link to Webrev Comment