Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256888: Client manual test problem list update #1396

Closed
wants to merge 2 commits into from
Closed

8256888: Client manual test problem list update #1396

wants to merge 2 commits into from

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Nov 23, 2020

Update the problem list.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1396/head:pull/1396
$ git checkout pull/1396

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 23, 2020

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2020

@prrace To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@prrace
Copy link
Contributor Author

@prrace prrace commented Dec 9, 2020

/label add 2d,awt,swing

@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2020

@prrace
The 2d label was successfully added.

The awt label was successfully added.

The swing label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 9, 2020

Webrevs

@@ -874,7 +874,7 @@ java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java 8068378 generic-all
java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html 8080185 macosx-all,linux-all
javax/swing/JTabbedPane/4666224/bug4666224.html 8144124 macosx-all
java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java 8162380 generic-all
java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java 8163086 macosx-all
java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java 8163086 macosx-all,linux-all
Copy link
Member

@mrserb mrserb Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure of this test on Linux was reported on 02.2019 last time. Since then only the problem on macOS is reported. Does the test actually fail on Linux right now?

@@ -886,5 +886,11 @@ java/awt/print/PrinterJob/ScaledText/ScaledText.java 8231226 macosx-all
java/awt/font/TextLayout/TestJustification.html 8250791 macosx-all
javax/swing/JTabbedPane/4209065/bug4209065.java 8251177 macosx-all
java/awt/TrayIcon/DragEventSource/DragEventSource.java 8252242 macosx-all
java/awt/FileDialog/DefaultFocusOwner/DefaultFocusOwner.java 7187728 macosx-all,linux-all,solaris-all
Copy link
Member

@mrserb mrserb Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Al usage of Solaris-xxx in the problem list was removed by the 071bd52#diff-80063aaf72a19fa27f001c17fc7687086ea71b35b01f5e2b3fcd7f50d8c682fbL252

@prrace
Copy link
Contributor Author

@prrace prrace commented Dec 10, 2020

I've removed the references to Solaris and the reference to Linux that was not needed.

mrserb
mrserb approved these changes Dec 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2020

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256888: Client manual test problem list update

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 327 new commits pushed to the master branch:

  • eb1c8a1: 8257924: Use full path when running external executable from jpackage
  • 1ce2a36: 8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618
  • 53e537c: 8255387: Japanese characters were printed upside down on AIX
  • 0a3e446: 8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently
  • 46c9a86: 8245956: JavaCompiler still uses File API instead of Path API in a specific case
  • baf4c1a: 8257917: [JVMCI] crash when materializing boxed values under -Xcomp
  • fd5f6e2: 8257986: [JVMCI] ProblemList 2 reprofile JVMCI tests
  • 30de320: 6882207: Convert javap to use diamond operator internally
  • d33a689: 8256867: Classes with empty PermittedSubclasses attribute cannot be extended
  • e6b4c4d: 8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in various ways
  • ... and 317 more: https://git.openjdk.java.net/jdk/compare/edf72f065ff9a0429c4290df1da4b52a6dcbb5ed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 10, 2020
@prrace
Copy link
Contributor Author

@prrace prrace commented Dec 10, 2020

/integrate

@openjdk openjdk bot closed this Dec 10, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2020

@prrace Since your change was applied there have been 327 commits pushed to the master branch:

  • eb1c8a1: 8257924: Use full path when running external executable from jpackage
  • 1ce2a36: 8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618
  • 53e537c: 8255387: Japanese characters were printed upside down on AIX
  • 0a3e446: 8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently
  • 46c9a86: 8245956: JavaCompiler still uses File API instead of Path API in a specific case
  • baf4c1a: 8257917: [JVMCI] crash when materializing boxed values under -Xcomp
  • fd5f6e2: 8257986: [JVMCI] ProblemList 2 reprofile JVMCI tests
  • 30de320: 6882207: Convert javap to use diamond operator internally
  • d33a689: 8256867: Classes with empty PermittedSubclasses attribute cannot be extended
  • e6b4c4d: 8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in various ways
  • ... and 317 more: https://git.openjdk.java.net/jdk/compare/edf72f065ff9a0429c4290df1da4b52a6dcbb5ed...master

Your commit was automatically rebased without conflicts.

Pushed as commit f631a99.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prrace prrace deleted the pl_update branch Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants