8304685: Fix whitespace parsing in libjdwp

[kevinjwalls]

Problem call to skipWhitespace in dbgsysExec src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c:91

We call skipWhitespace even when the loop will terminate, should guard against the last skipWhitespace call on the last iteration.

Could be done differently with the skipWhitespace call at the start of the loop, but skipped on the first iteration, but leaving the statements in the loop in the same order seems more readable.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304685: Fix whitespace parsing in libjdwp

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Alex Menkov (@alexmenkov - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13964/head:pull/13964
$ git checkout pull/13964

Update a local copy of the PR:
$ git checkout pull/13964
$ git pull https://git.openjdk.org/jdk.git pull/13964/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13964

View PR using the GUI difftool:
$ git pr show -t 13964

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13964.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinjwalls The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1b183f54)
• 00: Full (762566ed)

[plummercj]

Looks good!

[sspitsyn]

Looks good.
Thanks,
Serguei

[kevinjwalls]

Thanks for the reviews!

[openjdk]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304685: Fix whitespace parsing in libjdwp

Reviewed-by: cjplummer, amenkov, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 101 new commits pushed to the master branch:

• 241455f: 8307962: Exclude gc/g1/TestSkipRebuildRemsetPhase.java fails with virtual test thread factory
• 34468e1: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
• f0aebc8: 8305972: Update XML Security for Java to 3.0.2
• 265f40b: 8308396: Fix offset_of conversion warnings in runtime code
• a5343fa: 8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB
• 44218b1: 8308248: Revisit alignment of layout constants on 32-bit platforms
• 80ef5c2: 8308410: broken compilation of test\jdk\tools\launcher\exeJliLaunchTest.c
• 326d778: 8306057: False arguments calling dispatch_base for aarch64
• 690d396: 8308408: Build failure with -Werror=maybe-uninitialized in libjli/java.c with GCC8
• fa14314: 8303669: SelectVersion indexes past the end of the argv array
• ... and 91 more: https://git.openjdk.org/jdk/compare/6ebea8973feb08a7443d8d86ff52f453dc4aec43...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinjwalls]

/integrate

[openjdk]

Going to push as commit 939344b.
Since your change was applied there have been 101 commits pushed to the master branch:

• 241455f: 8307962: Exclude gc/g1/TestSkipRebuildRemsetPhase.java fails with virtual test thread factory
• 34468e1: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
• f0aebc8: 8305972: Update XML Security for Java to 3.0.2
• 265f40b: 8308396: Fix offset_of conversion warnings in runtime code
• a5343fa: 8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB
• 44218b1: 8308248: Revisit alignment of layout constants on 32-bit platforms
• 80ef5c2: 8308410: broken compilation of test\jdk\tools\launcher\exeJliLaunchTest.c
• 326d778: 8306057: False arguments calling dispatch_base for aarch64
• 690d396: 8308408: Build failure with -Werror=maybe-uninitialized in libjli/java.c with GCC8
• fa14314: 8303669: SelectVersion indexes past the end of the argv array
• ... and 91 more: https://git.openjdk.org/jdk/compare/6ebea8973feb08a7443d8d86ff52f453dc4aec43...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls Pushed as commit 939344b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.