8308041: [JVMCI] WB_IsGCSupportedByJVMCICompiler must enter correct JVMCI env

[dougxc]

The WB_IsGCSupportedByJVMCICompiler function in whitebox.cpp must use the same JVMCI environment (i.e. jarjvmci or libjvmci) that will be used by the CompileBroker. Otherwise, the question is being asked to the wrong JVMCI compiler implementation (which may not even exist in one of the 2 possible JVMCI environments).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308041: [JVMCI] WB_IsGCSupportedByJVMCICompiler must enter correct JVMCI env

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13971/head:pull/13971
$ git checkout pull/13971

Update a local copy of the PR:
$ git checkout pull/13971
$ git pull https://git.openjdk.org/jdk.git pull/13971/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13971

View PR using the GUI difftool:
$ git pr show -t 13971

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13971.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ae1a4cfd)

[TobiHartmann]

Looks good to me.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308041: [JVMCI] WB_IsGCSupportedByJVMCICompiler must enter correct JVMCI env

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 0ee196b: 8307163: JLONG_FORMAT_SPECIFIER should be updated on Windows
• 3709344: 8291550: RISC-V: jdk uses misaligned memory access when AvoidUnalignedAccess enabled
• 646747f: 8307926: Support byte-sized atomic bitset operations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Just wondering, should there be a test for this scenario?

[dougxc]

It's very hard to test as this is part of test setup. Also, you need libgraal to really test it properly and that's not (yet) part of the JDK.

[TobiHartmann]

Okay, thanks for the details.

[dougxc]

Thanks for the review @TobiHartmann .

/integrate

[openjdk]

Going to push as commit c9b6bb5.
Since your change was applied there have been 20 commits pushed to the master branch:

• 0790f70: 8306806: JMX agent with JDP enabled won't start when PerfData is disabled
• c2ef302: 8307968: serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java timed out
• d22bcc8: 8307403: java/util/zip/DeInflate.java timed out
• 2210e06: 8306638: Open source some AWT tests related to datatransfer and Toolkit
• 05b51c7: 8307567: Avoid relocating global roots to metaspaceObjs in CDS dump
• 3168372: 8306597: Improve string formatting in EquivMapsGenerator.java
• 7b0b9b5: 8308049: Refactor nested class declarations in FdLibm.java
• cc80ada: 8306593: Fix nsk/jdi/stop/stop001 for virtual threads and remove from problem list
• 43c8c65: 8307555: Reduce memory reads in x86 MD5 intrinsic
• 01892f9: 8304913: Use OperatingSystem, Architecture, and Version in jlink
• ... and 10 more: https://git.openjdk.org/jdk/compare/f030937a51b95dde33ce33537ee830153b2c3b56...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit c9b6bb5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.