8308091: Remove unused iRegIHeapbase() matching operand

[zhengxiaolinX]

The iRegIHeapbase() matching operand has no usage on both AArch64 and RISC-V platforms after JDK-8242449 and JDK-8306667, respectively. As the following-up action discussed in the code review process of JDK-8306667 (#13577), this is a small cleanup for the iRegIHeapbase() matching operand.

Passed fastdebug/release build on both AArch64/RISC-V platforms.

Thanks,
Xiaolin

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308091: Remove unused iRegIHeapbase() matching operand

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13983/head:pull/13983
$ git checkout pull/13983

Update a local copy of the PR:
$ git checkout pull/13983
$ git pull https://git.openjdk.org/jdk.git pull/13983/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13983

View PR using the GUI difftool:
$ git pr show -t 13983

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13983.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back xlinzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhengxiaolinX The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c26b96c9)
• 00: Full (41d36c4e)

[RealFYang]

Maybe we should remove reg_class heapbase_reg at the same time?

[zhengxiaolinX]

Maybe we should remove reg_class heapbase_reg at the same time?

Thanks, that's reasonable. Changes passed AArch64 hotspot tier1~4 (fastdebug). RISC-V hotspot tier1 is running.

[RealFYang]

Updated change LGTM. Thanks.

[openjdk]

@zhengxiaolinX This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308091: Remove unused iRegIHeapbase() matching operand

Reviewed-by: fyang, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 140 new commits pushed to the master branch:

• 2836c34: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts
• 8ffa264: 8306698: Add overloads to MethodTypeDesc::of
• 6b27dad: 8301154: SunPKCS11 KeyStore deleteEntry results in dangling PrivateKey entries
• ed0e956: 8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64
• bddf483: 8303942: os::write should write completely
• ab241b3: 8306706: Support out-of-line code generation for MachNodes
• 710453c: 8308016: Use snippets in java.io package
• e9320f3: 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files
• 97d3b27: 8307523: [vectorapi] Optimize MaskFromLongBenchmark.java
• bb0ff48: 8305091: Change ChaCha20 cipher init behavior to match AES-GCM
• ... and 130 more: https://git.openjdk.org/jdk/compare/8d49ba9e8d3095f850b3007b56488a0c0cf8ddff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[TobiHartmann]

Looks good to me too.

[zhengxiaolinX]

Thanks for reviewing! @RealFYang @TobiHartmann

This is a trivial patch, so integrate then.

/integrate

[openjdk]

@zhengxiaolinX
Your change (at version c26b96c) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 2d4d850.
Since your change was applied there have been 145 commits pushed to the master branch:

• b7a84b0: 8308758: Problemlist compiler/c2/irTests/TestVectorConditionalMove.java
• 20f1535: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview)
• 466ec30: 8302736: Major performance regression in Math.log on aarch64
• 05c095c: 8308151: [JVMCI] capture JVMCI exceptions in hs-err
• beb75e6: 8306302: C2 Superword fix: use VectorMaskCmp and VectorBlend instead of CMoveVF/D
• 2836c34: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts
• 8ffa264: 8306698: Add overloads to MethodTypeDesc::of
• 6b27dad: 8301154: SunPKCS11 KeyStore deleteEntry results in dangling PrivateKey entries
• ed0e956: 8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64
• bddf483: 8303942: os::write should write completely
• ... and 135 more: https://git.openjdk.org/jdk/compare/8d49ba9e8d3095f850b3007b56488a0c0cf8ddff...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @zhengxiaolinX Pushed as commit 2d4d850.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.