Skip to content

8308151: [JVMCI] capture JVMCI exceptions in hs-err #14000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

8308151: [JVMCI] capture JVMCI exceptions in hs-err #14000

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
26a1c42
make JMCI more robust in low resource conditions
dougxc May 10, 2023
348b3ae
remove unused callToString method
dougxc May 14, 2023
b1854a6
send JVMCI exception info to hs-err log and/or tty
dougxc May 15, 2023
9efd3ea
append elision comment to end of last stack trace line
dougxc May 16, 2023
90f4346
replace JVMCICompileMethodExceptionIsFatal VM flag with test.jvmci.co…
dougxc May 16, 2023
fb50cbb
Merge remote-tracking branch 'openjdk-jdk/master' into JDK-8308151
dougxc May 23, 2023
0471e7c
[skip ci] make TestUncaughtErrorInCompileMethod more robust
dougxc May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/hotspot/share/jvmci/jvmciEnv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,24 +322,33 @@ void JVMCIEnv::describe_pending_exception(outputStream* st) {
char* cursor = stack_trace;
int line = 0;
const int max_lines = LogEventsBufferEntries / 2;
char* last_line = nullptr;
while (*cursor != '\0') {
char* eol = strchr(cursor, '\n');
if (eol == nullptr) {
if (line < max_lines) {
if (line == max_lines - 1) {
last_line = cursor;
} else if (line < max_lines) {
JVMCI_event_1("%s", cursor);
}
cursor = cursor + strlen(cursor);
} else {
*eol = '\0';
if (line < max_lines) {
if (line == max_lines - 1) {
last_line = cursor;
} else if (line < max_lines) {
JVMCI_event_1("%s", cursor);
}
cursor = eol + 1;
}
line++;
}
if (line >= max_lines) {
JVMCI_event_1("[elided %d more stack trace lines]", line - max_lines);
if (last_line != nullptr) {
if (line > max_lines) {
JVMCI_event_1("%s [elided %d more stack trace lines]", last_line, line - max_lines);
} else {
JVMCI_event_1("%s", last_line);
}
}
}
}
Expand Down