-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8299075: TestStringDeduplicationInterned.java fails because extra deduplication #14005
Conversation
👋 Welcome back stefank! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One comment nit.
@@ -410,6 +405,15 @@ public static void main(String[] args) { | |||
System.out.println("End: InternedTest"); | |||
} | |||
|
|||
private static void checkNotDeduplicated(Object value1, Object value2) { | |||
// Note that the following check is invalid since a concurrent GC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the word "concurrent" can be dropped - it seems like any GC could trip over the problem.
It's just that the STW GCs are unlikely to occur and trip this because the various forceDeduplication
calls force GCs at those points, making automatically triggered GCs elsewhere unlikely.
@stefank This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review! I'd like to get this pushed ASAP since it intermittently fails in tier2. |
I'm going to integrate this now. Thanks! |
Going to push as commit 682359c.
Your commit was automatically rebased without conflicts. |
The tests assumes that some strings have not been deduplicated and checks for that. Unfortunately, we can have concurrently triggered GCs that invalidate those checks. I kept the call sites to show the intention of the test, but then I added a comment explaining why those checks are invalid.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14005/head:pull/14005
$ git checkout pull/14005
Update a local copy of the PR:
$ git checkout pull/14005
$ git pull https://git.openjdk.org/jdk.git pull/14005/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14005
View PR using the GUI difftool:
$ git pr show -t 14005
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14005.diff
Webrev
Link to Webrev Comment