8308181: Generational ZGC: Remove CLDG_lock from old gen root scanning

[fisk]

We already removed the CLDG_lock from young gen root scanning, after the CLDG was made concurrently walkable with JDK-8307106. We should remove it from the old generation root scanning code as well.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308181: Generational ZGC: Remove CLDG_lock from old gen root scanning

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Axel Boldt-Christmas (@xmas92 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14011/head:pull/14011
$ git checkout pull/14011

Update a local copy of the PR:
$ git checkout pull/14011
$ git pull https://git.openjdk.org/jdk.git pull/14011/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14011

View PR using the GUI difftool:
$ git pr show -t 14011

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14011.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back eosterlund! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fisk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cbb095a0)

[openjdk]

@fisk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308181: Generational ZGC: Remove CLDG_lock from old gen root scanning

Reviewed-by: ayang, aboldtch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 1a6f981: 8308185: Update Http2TestServerConnection to use SSLSocket.startHandshake()
• b300e73: 8308088: Improve class check in CollectedHeap::is_oop
• e34ecc9: 8296469: Instrument VMError::report with reentrant iteration step for register and stack printing
• 5a92aae: 8308156: VerifyCACerts.java misses blank in error output
• 2f1c654: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'
• d3e5065: 8306460: Clear JVM_ACC_QUEUED flag on methods when dumping dynamic CDS archive
• 563152f: 8308223: failure handler missed jcmd.vm.info command
• cb8b8cd: 8307458: Add periodic heap usage JFR events
• f9a785e: 8307547: Support variant collations
• 4e92991: 8300794: Use @snippet in java.util:i18n
• ... and 12 more: https://git.openjdk.org/jdk/compare/72294c5402dd11e3eb4922ad26e1b153098495ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[fisk]

Thanks for the reviews @xmas92 and @albertnetymk!

[fisk]

/integrate

[openjdk]

Going to push as commit 8011ba7.
Since your change was applied there have been 75 commits pushed to the master branch:

• 8aa5028: 8302344: Compiler Implementation for Unnamed patterns and variables (Preview)
• b588797: 8307804: Reorganize ArrayJuggle test cases
• 928fcf9: 8308000: add PopFrame support for virtual threads
• 41beb44: 8308084: C2 fix idom bug in PhaseIdealLoop::create_new_if_for_predicate
• b6a9f5c: 8307619: C2 failed: Not monotonic (AndI CastII LShiftI) in TestShiftCastAndNotification.java
• eaa80ad: 8300543: Compiler Implementation for Pattern Matching for switch
• 5ccc962: 8308342: Remove MetaspaceClosure::Ref::keep_after_pushing()
• a0f4a94: 8307783: runtime/reflect/ReflectOutOfMemoryError.java timed out
• 939344b: 8304685: Fix whitespace parsing in libjdwp
• 241455f: 8307962: Exclude gc/g1/TestSkipRebuildRemsetPhase.java fails with virtual test thread factory
• ... and 65 more: https://git.openjdk.org/jdk/compare/72294c5402dd11e3eb4922ad26e1b153098495ff...master

Your commit was automatically rebased without conflicts.

[openjdk]

@fisk Pushed as commit 8011ba7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.