Skip to content

8308188: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC on all platforms #14014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

stefank
Copy link
Member

@stefank stefank commented May 16, 2023

We've now seen this failure on MacOS as well. It's time to problem-list this test on all platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308188: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC on all platforms

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14014/head:pull/14014
$ git checkout pull/14014

Update a local copy of the PR:
$ git checkout pull/14014
$ git pull https://git.openjdk.org/jdk.git pull/14014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14014

View PR using the GUI difftool:
$ git pr show -t 14014

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14014.diff

Webrev

Link to Webrev Comment

@stefank
Copy link
Member Author

stefank commented May 16, 2023

/label add hotspot

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2023

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot hotspot-dev@openjdk.org labels May 16, 2023
@openjdk
Copy link

openjdk bot commented May 16, 2023

@stefank
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented May 16, 2023

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@openjdk
Copy link

openjdk bot commented May 16, 2023

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308188: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC on all platforms

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 23cbb2d: 8306860: Avoid unnecessary allocation in List.map() when list is empty

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 16, 2023
@stefank
Copy link
Member Author

stefank commented May 16, 2023

Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented May 16, 2023

Going to push as commit 316bc79.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 8686a36: 8307315: Missing ResourceMark in CDS and JVMTI code
  • 23cbb2d: 8306860: Avoid unnecessary allocation in List.map() when list is empty

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2023
@openjdk openjdk bot closed this May 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2023
@openjdk
Copy link

openjdk bot commented May 16, 2023

@stefank Pushed as commit 316bc79.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants