8308283: Build failure with GCC12 & GCC13 #14032

xpbob · 2023-05-17T12:26:22Z

configure --enable-debug

error: infinite recursion detected [-Werror=infinite-recursion]
  193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)

configure

java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-common.hh:1161:24: error: possibly dangling reference to a temporary [-Werror=dangling-reference]
 1161 | const LangSys& l = this+_.second.offset;

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

JDK-8308283: Build failure with GCC12 & GCC13

Reviewers

Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to 1c80f579
Jie Fu (@DamonFool - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14032/head:pull/14032
$ git checkout pull/14032

Update a local copy of the PR:
$ git checkout pull/14032
$ git pull https://git.openjdk.org/jdk.git pull/14032/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14032

View PR using the GUI difftool:
$ git pr show -t 14032

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14032.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-05-17T12:27:23Z

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-05-17T12:30:20Z

@xpbob The following labels will be automatically applied to this pull request:

build
client
hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-05-17T12:33:55Z

Webrevs

erikj79

Build changes look good. Someone from hotspot should also weigh in.

/reviewers 2

openjdk · 2023-05-17T13:08:04Z

@xpbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308283: Build failure with GCC12 & GCC13

Reviewed-by: erikj, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

57b8ed1: 8308290: Add fontconfig requirement to building.md
3c9ec26: 8306457: Classfile API components implementations should not be exposed
f4f5542: 8306842: Classfile API performance improvements
95da499: 8308285: Assert on -Xshare:dump when running with -Xlog:cds=trace
6f75dd8: 8308236: Remove SystemDictionaryShared::clone_dumptime_tables()
83c096d: 8308270: ARM32 build broken after JDK-8304913
902585b: 8308110: Resolve multiple definition of 'JNI_OnLoad_jsound' linking error
6073edf: 8307483: New micros for j.u.c.LockSupport
2409448: 8307365: JvmtiStressModule hit SIGSEGV in JvmtiEventControllerPrivate::recompute_thread_enabled
950c5df: 8307299: Move more DnD tests to open
... and 8 more: https://git.openjdk.org/jdk/compare/b300e73a4acb5c64f68a355e0ad70d3862084ff4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @DamonFool) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2023-05-17T13:08:32Z

@erikj79
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

prrace · 2023-05-17T18:49:44Z

This is a duplicate of https://bugs.openjdk.org/browse/JDK-8307210
Please check for existing reports before creating a new bug.
We already plan to fix this before we officially upgrade to 13.1, until then you just disable the warning.

DamonFool · 2023-05-17T23:05:57Z

This is a duplicate of https://bugs.openjdk.org/browse/JDK-8307210

I don't think so since it also fixes the build broken due to -Werror=infinite-recursion.
Actually, -Werror=infinite-recursion was first introduced in GCC12.
So the build will also fail with GCC12.

Please check for existing reports before creating a new bug. We already plan to fix this before we officially upgrade to 13.1, until then you just disable the warning.

I think it's fine to just disable the warning before you have cycles to fix it since it's a third-party code.
Now part of our testing machines had been upgrade to GCC13 so it would be good to fix it as soon as possible.
Thanks.

DamonFool · 2023-05-17T23:21:59Z

@xpbob , maybe, it would be better to change the JBS title with something like Build failure with GCC12 & GCC13?

xpbob · 2023-05-18T02:06:30Z

@prrace hi
I found the error: infinite recursion detected [-Werror=infinite-recursion] message and check the information in existing reports,There are no similar bugs.

xpbob · 2023-05-18T02:15:51Z

@DamonFool @prrace
I have changed the JBS title

DamonFool · 2023-05-18T02:35:33Z

src/hotspot/share/utilities/compilerWarnings_gcc.hpp

@@ -44,6 +44,11 @@
 #define PRAGMA_DANGLING_POINTER_IGNORED PRAGMA_DISABLE_GCC_WARNING("-Wdangling-pointer")
 #endif

+// Disable -Winfinite-recursion which is introduced in GCC 12.
+#if !defined(__clang_major__) && (__GNUC__ >= 12)
+#define PRAGMA_INFINITE_RECURSION_IGNORED PRAGMA_DISABLE_GCC_WARNING("-Winfinite-recursion")


How about moving this line after Line 44?

xpbob · 2023-05-18T03:19:03Z

@DamonFool
Thanks for the review,The code has been updated

DamonFool

LGTM
Thanks for the update.

xpbob · 2023-05-18T12:11:17Z

/integrate

openjdk · 2023-05-18T12:12:30Z

@xpbob
Your change (at version 34906c9) is now ready to be sponsored by a Committer.

DamonFool · 2023-05-18T12:26:05Z

/sponsor

openjdk · 2023-05-18T12:26:56Z

Going to push as commit bfc3ccd.
Since your change was applied there have been 18 commits pushed to the master branch:

57b8ed1: 8308290: Add fontconfig requirement to building.md
3c9ec26: 8306457: Classfile API components implementations should not be exposed
f4f5542: 8306842: Classfile API performance improvements
95da499: 8308285: Assert on -Xshare:dump when running with -Xlog:cds=trace
6f75dd8: 8308236: Remove SystemDictionaryShared::clone_dumptime_tables()
83c096d: 8308270: ARM32 build broken after JDK-8304913
902585b: 8308110: Resolve multiple definition of 'JNI_OnLoad_jsound' linking error
6073edf: 8307483: New micros for j.u.c.LockSupport
2409448: 8307365: JvmtiStressModule hit SIGSEGV in JvmtiEventControllerPrivate::recompute_thread_enabled
950c5df: 8307299: Move more DnD tests to open
... and 8 more: https://git.openjdk.org/jdk/compare/b300e73a4acb5c64f68a355e0ad70d3862084ff4...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-05-18T12:27:18Z

@DamonFool @xpbob Pushed as commit bfc3ccd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8308283: Build failure with gcc 13.1.0

1c80f57

openjdk bot added the rfr Pull request is ready for review label May 17, 2023

openjdk bot added hotspot hotspot-dev@openjdk.org build build-dev@openjdk.org client client-libs-dev@openjdk.org labels May 17, 2023

erikj79 approved these changes May 17, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 17, 2023

openjdk bot removed the ready Pull request is ready to be integrated label May 17, 2023

xpbob changed the title ~~8308283: Build failure with gcc 13.1.0~~ 8308283: Build failure with GCC12 & GCC13 May 18, 2023

DamonFool reviewed May 18, 2023

View reviewed changes

bobpengxie added 2 commits May 18, 2023 11:01

merge line

3da4737

remove blank

34906c9

DamonFool approved these changes May 18, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 18, 2023

openjdk bot added the sponsor Pull request is ready to be sponsored label May 18, 2023

openjdk bot added the integrated Pull request has been integrated label May 18, 2023

openjdk bot closed this May 18, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8308283: Build failure with GCC12 & GCC13 #14032

8308283: Build failure with GCC12 & GCC13 #14032

xpbob commented May 17, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented May 17, 2023

openjdk bot commented May 17, 2023

mlbridge bot commented May 17, 2023 •

edited

Loading

erikj79 left a comment

openjdk bot commented May 17, 2023 •

edited

Loading

openjdk bot commented May 17, 2023

prrace commented May 17, 2023

DamonFool commented May 17, 2023

DamonFool commented May 17, 2023

xpbob commented May 18, 2023

xpbob commented May 18, 2023

DamonFool May 18, 2023

xpbob commented May 18, 2023

DamonFool left a comment

xpbob commented May 18, 2023

openjdk bot commented May 18, 2023

DamonFool commented May 18, 2023

openjdk bot commented May 18, 2023

openjdk bot commented May 18, 2023

8308283: Build failure with GCC12 & GCC13 #14032

8308283: Build failure with GCC12 & GCC13 #14032

Conversation

xpbob commented May 17, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented May 17, 2023

openjdk bot commented May 17, 2023

mlbridge bot commented May 17, 2023 • edited Loading

Webrevs

erikj79 left a comment

Choose a reason for hiding this comment

openjdk bot commented May 17, 2023 • edited Loading

openjdk bot commented May 17, 2023

prrace commented May 17, 2023

DamonFool commented May 17, 2023

DamonFool commented May 17, 2023

xpbob commented May 18, 2023

xpbob commented May 18, 2023

DamonFool May 18, 2023

Choose a reason for hiding this comment

xpbob commented May 18, 2023

DamonFool left a comment

Choose a reason for hiding this comment

xpbob commented May 18, 2023

openjdk bot commented May 18, 2023

DamonFool commented May 18, 2023

openjdk bot commented May 18, 2023

openjdk bot commented May 18, 2023

xpbob commented May 17, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented May 17, 2023 •

edited

Loading

openjdk bot commented May 17, 2023 •

edited

Loading