Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308283: Build failure with GCC12 & GCC13 #14032

Closed
wants to merge 3 commits into from

Conversation

xpbob
Copy link
Contributor

@xpbob xpbob commented May 17, 2023

configure --enable-debug

error: infinite recursion detected [-Werror=infinite-recursion]
  193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)

configure

java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-common.hh:1161:24: error: possibly dangling reference to a temporary [-Werror=dangling-reference]
 1161 | const LangSys& l = this+_.second.offset; 

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14032/head:pull/14032
$ git checkout pull/14032

Update a local copy of the PR:
$ git checkout pull/14032
$ git pull https://git.openjdk.org/jdk.git pull/14032/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14032

View PR using the GUI difftool:
$ git pr show -t 14032

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14032.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2023

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 17, 2023
@openjdk
Copy link

openjdk bot commented May 17, 2023

@xpbob The following labels will be automatically applied to this pull request:

  • build
  • client
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org build build-dev@openjdk.org client client-libs-dev@openjdk.org labels May 17, 2023
@mlbridge
Copy link

mlbridge bot commented May 17, 2023

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build changes look good. Someone from hotspot should also weigh in.

/reviewers 2

@openjdk
Copy link

openjdk bot commented May 17, 2023

@xpbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308283: Build failure with GCC12 & GCC13

Reviewed-by: erikj, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @DamonFool) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 17, 2023
@openjdk
Copy link

openjdk bot commented May 17, 2023

@erikj79
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 17, 2023
@prrace
Copy link
Contributor

prrace commented May 17, 2023

This is a duplicate of https://bugs.openjdk.org/browse/JDK-8307210
Please check for existing reports before creating a new bug.
We already plan to fix this before we officially upgrade to 13.1, until then you just disable the warning.

@DamonFool
Copy link
Member

This is a duplicate of https://bugs.openjdk.org/browse/JDK-8307210

I don't think so since it also fixes the build broken due to -Werror=infinite-recursion.
Actually, -Werror=infinite-recursion was first introduced in GCC12.
So the build will also fail with GCC12.

Please check for existing reports before creating a new bug. We already plan to fix this before we officially upgrade to 13.1, until then you just disable the warning.

I think it's fine to just disable the warning before you have cycles to fix it since it's a third-party code.
Now part of our testing machines had been upgrade to GCC13 so it would be good to fix it as soon as possible.
Thanks.

@DamonFool
Copy link
Member

@xpbob , maybe, it would be better to change the JBS title with something like Build failure with GCC12 & GCC13?

@xpbob
Copy link
Contributor Author

xpbob commented May 18, 2023

@prrace hi
I found the error: infinite recursion detected [-Werror=infinite-recursion] message and check the information in existing reports,There are no similar bugs.

@xpbob xpbob changed the title 8308283: Build failure with gcc 13.1.0 8308283: Build failure with GCC12 & GCC13 May 18, 2023
@xpbob
Copy link
Contributor Author

xpbob commented May 18, 2023

@DamonFool @prrace
I have changed the JBS title

@@ -44,6 +44,11 @@
#define PRAGMA_DANGLING_POINTER_IGNORED PRAGMA_DISABLE_GCC_WARNING("-Wdangling-pointer")
#endif

// Disable -Winfinite-recursion which is introduced in GCC 12.
#if !defined(__clang_major__) && (__GNUC__ >= 12)
#define PRAGMA_INFINITE_RECURSION_IGNORED PRAGMA_DISABLE_GCC_WARNING("-Winfinite-recursion")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving this line after Line 44?

@xpbob
Copy link
Contributor Author

xpbob commented May 18, 2023

@DamonFool
Thanks for the review,The code has been updated

Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the update.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 18, 2023
@xpbob
Copy link
Contributor Author

xpbob commented May 18, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 18, 2023
@openjdk
Copy link

openjdk bot commented May 18, 2023

@xpbob
Your change (at version 34906c9) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 18, 2023

Going to push as commit bfc3ccd.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 18, 2023
@openjdk openjdk bot closed this May 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 18, 2023
@openjdk
Copy link

openjdk bot commented May 18, 2023

@DamonFool @xpbob Pushed as commit bfc3ccd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org client client-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
4 participants