JDK-8308350: Increase buffer size for jspawnhelper arguments

[tstuefe]

Trivial fix for a small problem.

jspawnhelper gets handed several file descriptors as arguments. The buffer size for this string is too small (7 chars per fd) to print out every conceivable int. This will overun the buffer if we happen to have fds larger than (printed size) 7 characters. This could lead to crashes or malfunctions if the parent VM has opened a large amount of file descriptors.

Note that on Linux, this can normally not happen since the kernel limits the number of open file descriptors per process to 1M, and these fds are still printable within the limits of this buffer. It is possible to get more fds per process, but only via kernel patch. But we still should not rely on that. And there is also still MacOS using the same mechanism.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308350: Increase buffer size for jspawnhelper arguments

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14045/head:pull/14045
$ git checkout pull/14045

Update a local copy of the PR:
$ git checkout pull/14045
$ git pull https://git.openjdk.org/jdk.git pull/14045/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14045

View PR using the GUI difftool:
$ git pr show -t 14045

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14045.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[tstuefe]

GHAs are all suffering from infrastructure problems.

[mlbridge]

Webrevs

• 01: Full - Incremental (dbce7ce1)
• 00: Full (6fda35fb)

[RogerRiggs]

Trivial

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308350: Increase buffer size for jspawnhelper arguments

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• bfc3ccd: 8308283: Build failure with GCC12 & GCC13

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Thanks @RogerRiggs !

/integrate

[openjdk]

Going to push as commit 808dc1b.
Since your change was applied there have been 2 commits pushed to the master branch:

• a58e0ca: 8308347: [s390x] build broken after JDK-8304913
• bfc3ccd: 8308283: Build failure with GCC12 & GCC13

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit 808dc1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.