8305225: A service broken error despite annotation processor generating it if directives listed

[lahodaj]

Consider code like:

module m {
     provides api.Api with impl.Impl; //impl.Impl is not in sources, but is generated by an annotation processor
}

This works fine, until the processor asks for the given module's directives, in which case the build fails with an error like:

testCreateProvidesWithAP/src/m/module-info.java:2: error: the service implementation does not have a default constructor: Test
    provides api.Api with test.Test;

The cause for this error is that when the directive is analyzed, the test.Test is attributed (and any errors from that are delayed due to the annotation processing), but even though it attributes to an erroneous type, it will still be checked whether it has the appropriate constructor, etc.

The proposal is to skip the additional checks when the type is an erroneous type. Errors for it should have been reported and handled appropriately (i.e. ignored if resolved by an AP, or reported if not), there does not seem to be any reason to produce any further errors related to the missing type.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305225: A service broken error despite annotation processor generating it if directives listed

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14046/head:pull/14046
$ git checkout pull/14046

Update a local copy of the PR:
$ git checkout pull/14046
$ git pull https://git.openjdk.org/jdk.git pull/14046/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14046

View PR using the GUI difftool:
$ git pr show -t 14046

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14046.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b345804f)

[asotona]

It looks good 👍

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305225: A service broken error despite annotation processor generating it if directives listed

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 288 new commits pushed to the master branch:

• 59d9d9f: 8303215: Make thread stacks not use huge pages
• cb1e5e3: 8309286: G1: Remove unused G1HeapRegionAttr::is_valid_gen
• e8268d9: 8309210: Extend VM Operations hs_err logging
• 7dbdad5: 8308892: Bad graph detected in build_loop_late after JDK-8305635
• dc8bc6c: 8308090: Add container tests for on-the-fly resource quota updates
• 73e7af9: 8309287: Add fontconfig requirement to building.md for Debian
• aeb53e6: 8308711: Develop additional Tests for KEM implementation
• dcd9590: 8309224: Fix xlc17 clang 15 warnings in java.desktop
• 8f1ce78: 8308752: Generational ZGC: Avoid final marking through stack chunks
• 7b0a336: 8308387: CLD created and unloading list sharing _next node pointer leads to concurrent YC missing CLD roots
• ... and 278 more: https://git.openjdk.org/jdk/compare/97b2ca3de76046c6f52d3649d8787feea7b9ac83...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit b6c9232.
Since your change was applied there have been 301 commits pushed to the master branch:

• 05fb6c6: 8309336: Incorrect switch in enum not reported properly
• 08c91c2: 8309332: RISC-V: Improve PrintOptoAssembly output of vector nodes
• ecb1753: 8309334: ProcessTools.main() does not properly set thread names when using the virtual thread wrapper
• ac1597b: 8309409: Update HttpInputStreamTest and BodyProcessorInputStreamTest to use hg.openjdk.org
• fdb5893: 8309391: Remove non-failing tests from test/jdk/ProblemList-Virtual.txt
• 6edd786: 8309265: Serial: Remove the code related to GC overheap limit
• 61bb014: 8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V
• 62c935d: 8308978: regression with a deadlock involving FollowReferences
• aff9cea: 8303530: Redefine JAXP Configuration File
• 1bb037b: 8309329: com/sun/jdi/DeferredStepTest.java fails with virtual threads due to not waiting for threads to exit
• ... and 291 more: https://git.openjdk.org/jdk/compare/97b2ca3de76046c6f52d3649d8787feea7b9ac83...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit b6c9232.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.