Skip to content

JDK-8308388: Update description of SourceVersion.RELEASE_21 #14051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented May 18, 2023

Update description of SourceVersion.RELEASE_21 for the new language features (once they are pushed).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308388: Update description of SourceVersion.RELEASE_21

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14051/head:pull/14051
$ git checkout pull/14051

Update a local copy of the PR:
$ git checkout pull/14051
$ git pull https://git.openjdk.org/jdk.git pull/14051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14051

View PR using the GUI difftool:
$ git pr show -t 14051

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14051.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 18, 2023

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 18, 2023
@openjdk
Copy link

openjdk bot commented May 18, 2023

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label May 18, 2023
@mlbridge
Copy link

mlbridge bot commented May 18, 2023

Webrevs

* 21: tbd
* 21: pattern matching for switch and record patterns (string
* templates in preview, unnamed patterns and variables, unnamed
* classes and instance main methods in preview
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* classes and instance main methods in preview
* classes and instance main methods in preview)

missing right parenthesis

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected; thanks @liach .

@openjdk
Copy link

openjdk bot commented May 18, 2023

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308388: Update description of SourceVersion.RELEASE_21

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • a0f4a94: 8307783: runtime/reflect/ReflectOutOfMemoryError.java timed out
  • 939344b: 8304685: Fix whitespace parsing in libjdwp
  • 241455f: 8307962: Exclude gc/g1/TestSkipRebuildRemsetPhase.java fails with virtual test thread factory
  • 34468e1: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
  • f0aebc8: 8305972: Update XML Security for Java to 3.0.2
  • 265f40b: 8308396: Fix offset_of conversion warnings in runtime code
  • a5343fa: 8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB
  • 44218b1: 8308248: Revisit alignment of layout constants on 32-bit platforms
  • 80ef5c2: 8308410: broken compilation of test\jdk\tools\launcher\exeJliLaunchTest.c
  • 326d778: 8306057: False arguments calling dispatch_base for aarch64
  • ... and 9 more: https://git.openjdk.org/jdk/compare/d3feedf5114542078c10abec0612038c88e005d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 18, 2023
@jddarcy
Copy link
Member Author

jddarcy commented May 22, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 22, 2023

Going to push as commit d77a410.
Since your change was applied there have been 41 commits pushed to the master branch:

  • 3f4cfbd: 8307190: Refactor ref_at methods in Constant Pool
  • 491bdea: 8308458: Windows build failure with disassembler.cpp(792): warning C4267: '=': conversion from 'size_t' to 'int'
  • b58980b: 8308034: Some CDS tests need to use @requires vm.flagless
  • 29b8d3d: 8307573: Implementation of JEP 449: Deprecate the Windows 32-bit x86 Port for Removal
  • 5fc9b57: 8308276: Change layout API to work with bytes, not bits
  • 91aeb5d: 8287834: Add SymbolLookup::or method
  • 4f88437: 8307908: [ppc] Add failing RTM tests to ProblemList until 8307907 is fixed.
  • dc30e68: 8308407: libjvm library not reproducibly comparable between vendors
  • 18e2446: 8301381: Verify DTLS 1.0 cannot be negotiated
  • b3cb82b: 8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests
  • ... and 31 more: https://git.openjdk.org/jdk/compare/d3feedf5114542078c10abec0612038c88e005d6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 22, 2023
@openjdk openjdk bot closed this May 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

@jddarcy Pushed as commit d77a410.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8308388 branch June 10, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants