8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone)

[gerard-ziemski]

Based on Thomas' comments from the bug, we fix it by removing the faulty assert, and instead we handle the case of "same site, different flags", as old site and new site.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone)

Reviewers

• Johan Sjölen (@jdksjolen - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14052/head:pull/14052
$ git checkout pull/14052

Update a local copy of the PR:
$ git checkout pull/14052
$ git pull https://git.openjdk.org/jdk.git pull/14052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14052

View PR using the GUI difftool:
$ git pr show -t 14052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14052.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gziemski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gerard-ziemski The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[gerard-ziemski]

@tstuefe @dholmes-ora I closed PR 13993, because I thought it would take me a while to think of a way to fix this correctly, but after thinking for a bit I came up with this one, hence new PR. Sorry for making you jump.

[gerard-ziemski]

If Thomas likes this approach I will move it out of draft.

[jdksjolen]

Hi Gerard,

Following the discussions in the JBS ticket and previous PRs I think that this solution makes sense. Thank you.

[tstuefe]

Good.

[gerard-ziemski]

Thank you Johan and Thomas!

[openjdk]

@gerard-ziemski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone)

Reviewed-by: jsjolen, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 131 new commits pushed to the master branch:

• c72b547: 8308801: update for deprecated sprintf for libnet in java.base
• 77c5adb: 8308935: jdk.management.jfr.RecordingInfo.toString() lacks test coverage
• ce5251a: 8308657: ReplayInline is not availabe in production build
• cc0976b: 8308589: gc/cslocker/TestCSLocker.java timed out
• 17ef8a4: 8299665: /proc/self/stat parsing in libmanagement broken by execname with spaces
• c494770: 8306812: Open source several AWT Miscellaneous tests
• d3b9b36: 8308009: Generational ZGC: OOM before clearing all SoftReferences
• bac02b6: 8305189: C2 failed "assert(_outcnt==1) failed: not unique"
• 62537d2: 8299974: Replace NULL with nullptr in share/adlc/
• f09345b: 8308931: Problemlist compiler/jvmci/TestUncaughtErrorInCompileMethod.java
• ... and 121 more: https://git.openjdk.org/jdk/compare/4a6d6d5a59442c10a1761ce0566aab57f4c4f323...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (1d26d97f)

[gerard-ziemski]

/integrate

[openjdk]

Going to push as commit ca54f4e.
Since your change was applied there have been 135 commits pushed to the master branch:

• 5fdb22f: 8308876: JFR: Deserialization of EventTypeInfo uses incorrect attribute names
• bd113ee: 8308814: extend SetLocalXXX minimal support for virtual threads
• a923634: 8286470: Support searching for sections in class/package javadoc
• 55d297f: 8308594: Use atomic bitset function for PackageEntry::_defined_by_cds_in_class_path
• c72b547: 8308801: update for deprecated sprintf for libnet in java.base
• 77c5adb: 8308935: jdk.management.jfr.RecordingInfo.toString() lacks test coverage
• ce5251a: 8308657: ReplayInline is not availabe in production build
• cc0976b: 8308589: gc/cslocker/TestCSLocker.java timed out
• 17ef8a4: 8299665: /proc/self/stat parsing in libmanagement broken by execname with spaces
• c494770: 8306812: Open source several AWT Miscellaneous tests
• ... and 125 more: https://git.openjdk.org/jdk/compare/4a6d6d5a59442c10a1761ce0566aab57f4c4f323...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gerard-ziemski Pushed as commit ca54f4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.