Skip to content

8308408: Build failure with -Werror=maybe-uninitialized in libjli/java.c with GCC8 #14057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented May 19, 2023

May I get review for this change which fixes the build broken with GCC8?
Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308408: Build failure with -Werror=maybe-uninitialized in libjli/java.c with GCC8

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14057/head:pull/14057
$ git checkout pull/14057

Update a local copy of the PR:
$ git checkout pull/14057
$ git pull https://git.openjdk.org/jdk.git pull/14057/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14057

View PR using the GUI difftool:
$ git pr show -t 14057

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14057.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2023

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 19, 2023
@openjdk
Copy link

openjdk bot commented May 19, 2023

@DamonFool The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 19, 2023
@mlbridge
Copy link

mlbridge bot commented May 19, 2023

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay

@openjdk
Copy link

openjdk bot commented May 19, 2023

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308408: Build failure with -Werror=maybe-uninitialized in libjli/java.c with GCC8

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 19, 2023
@DamonFool
Copy link
Member Author

This looks okay

Thanks @AlanBateman for your quick review.

May I push it now since it's a build breakage?
Thanks.

@AlanBateman
Copy link
Contributor

May I push it now since it's a build breakage? Thanks.

Yes, the change is trivial so please go ahead.

@DamonFool
Copy link
Member Author

May I push it now since it's a build breakage? Thanks.

Yes, the change is trivial so please go ahead.

Thanks @AlanBateman .
/integrate

@openjdk
Copy link

openjdk bot commented May 19, 2023

Going to push as commit 690d396.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 19, 2023
@openjdk openjdk bot closed this May 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 19, 2023
@openjdk
Copy link

openjdk bot commented May 19, 2023

@DamonFool Pushed as commit 690d396.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8308408 branch May 19, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants