Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301381: Verify DTLS 1.0 cannot be negotiated #14059

Closed
wants to merge 1 commit into from

Conversation

mpdonova
Copy link
Contributor

@mpdonova mpdonova commented May 19, 2023

This PR implements a test to verify that a DTLS server running "out of the box" (i.e., DTLSv1.0 disabled in java.security) will not handshake with a client requesting DTLSv1.0. The test also implements the opposite: a client won't handshake with a server that uses DTLSv1.0.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14059/head:pull/14059
$ git checkout pull/14059

Update a local copy of the PR:
$ git checkout pull/14059
$ git pull https://git.openjdk.org/jdk.git pull/14059/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14059

View PR using the GUI difftool:
$ git pr show -t 14059

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14059.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2023

👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 19, 2023
@openjdk
Copy link

openjdk bot commented May 19, 2023

@mpdonova The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 19, 2023
@mlbridge
Copy link

mlbridge bot commented May 19, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 19, 2023

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301381: Verify DTLS 1.0 cannot be negotiated

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 80ef5c2: 8308410: broken compilation of test\jdk\tools\launcher\exeJliLaunchTest.c
  • 326d778: 8306057: False arguments calling dispatch_base for aarch64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 19, 2023
@mpdonova
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 22, 2023

Going to push as commit 18e2446.
Since your change was applied there have been 23 commits pushed to the master branch:

  • b3cb82b: 8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests
  • 3d550f7: 8280993: [XWayland] Popup is not closed on click outside of area controlled by XWayland
  • 05e99db: 7065228: To interpret case-insensitive string locale independently
  • a970519: 8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms
  • 6b65e57: 8305785: Avoid redundant HashMap.containsKey call in java.util.regex
  • 8011ba7: 8308181: Generational ZGC: Remove CLDG_lock from old gen root scanning
  • 8aa5028: 8302344: Compiler Implementation for Unnamed patterns and variables (Preview)
  • b588797: 8307804: Reorganize ArrayJuggle test cases
  • 928fcf9: 8308000: add PopFrame support for virtual threads
  • 41beb44: 8308084: C2 fix idom bug in PhaseIdealLoop::create_new_if_for_predicate
  • ... and 13 more: https://git.openjdk.org/jdk/compare/690d3969b80776bf896fbfbfac5eabe7d074c9bb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 22, 2023
@openjdk openjdk bot closed this May 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

@mpdonova Pushed as commit 18e2446.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants