Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308540: On Kerberos TGT referral, if krb5.conf is missing realm, bad exception message #14086

Closed
wants to merge 1 commit into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented May 22, 2023

Add realm name to the exception message, and make it the primary exception (retry exception added suppressed).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308540: On Kerberos TGT referral, if krb5.conf is missing realm, bad exception message (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14086/head:pull/14086
$ git checkout pull/14086

Update a local copy of the PR:
$ git checkout pull/14086
$ git pull https://git.openjdk.org/jdk.git pull/14086/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14086

View PR using the GUI difftool:
$ git pr show -t 14086

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14086.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 22, 2023

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 22, 2023
@mlbridge
Copy link

mlbridge bot commented May 22, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2023

@wangweij This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@wangweij
Copy link
Contributor Author

Still worth fixing.

@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308540: On Kerberos TGT referral, if krb5.conf is missing realm, bad exception message

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 509 new commits pushed to the master branch:

  • 5ff42d1: 8303549: [AIX] TestNativeStack.java is failing with exit value 1
  • 24abd10: 8310192: RISC-V: Merge vector min & max instructs with similar match rules
  • 3357867: 8310276: RISC-V: Make use of shadd macro-assembler function when possible
  • c1c5bd0: 8310541: G1: Remove redundant check in G1Policy::need_to_start_conc_mark
  • 5271f4d: 8310354: G1: Annotate G1MMUTracker::when_sec with const
  • a420ff4: 6664309: Docking point of a floating toolbar changes after closing
  • a96e92c: 8310816: GcInfoBuilder float/double signature mismatch
  • c23794f: 8308633: Increase precision of timestamps in g1 log
  • 9397094: 8310540: G1: Verification should use raw oop decode functions
  • 013367b: 8310868: Thread.interrupt() method's javadoc has an incorrect {@link}
  • ... and 499 more: https://git.openjdk.org/jdk/compare/4f88437b7fc26e1d9b096b535a4dbfd8a9d227f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 26, 2023
@wangweij
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 26, 2023

Going to push as commit e624484.
Since your change was applied there have been 509 commits pushed to the master branch:

  • 5ff42d1: 8303549: [AIX] TestNativeStack.java is failing with exit value 1
  • 24abd10: 8310192: RISC-V: Merge vector min & max instructs with similar match rules
  • 3357867: 8310276: RISC-V: Make use of shadd macro-assembler function when possible
  • c1c5bd0: 8310541: G1: Remove redundant check in G1Policy::need_to_start_conc_mark
  • 5271f4d: 8310354: G1: Annotate G1MMUTracker::when_sec with const
  • a420ff4: 6664309: Docking point of a floating toolbar changes after closing
  • a96e92c: 8310816: GcInfoBuilder float/double signature mismatch
  • c23794f: 8308633: Increase precision of timestamps in g1 log
  • 9397094: 8310540: G1: Verification should use raw oop decode functions
  • 013367b: 8310868: Thread.interrupt() method's javadoc has an incorrect {@link}
  • ... and 499 more: https://git.openjdk.org/jdk/compare/4f88437b7fc26e1d9b096b535a4dbfd8a9d227f1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 26, 2023
@openjdk openjdk bot closed this Jun 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 26, 2023
@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@wangweij Pushed as commit e624484.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8308540 branch August 30, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants