8307814: In the case of two methods with Record Patterns, the second one contains a line number from the first method

[lahodaj]

TransPatterns is not setting the position for TreeMaker when unrolling record patterns, leading to weird content of the LineNumberTable. The proposal is to set the position.

For tests, it attempts to make the tests more general/allow more strict checks on the LNT.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307814: In the case of two methods with Record Patterns, the second one contains a line number from the first method

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)
• Evgeny Mandrikov (@Godin - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14087/head:pull/14087
$ git checkout pull/14087

Update a local copy of the PR:
$ git checkout pull/14087
$ git pull https://git.openjdk.org/jdk.git pull/14087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14087

View PR using the GUI difftool:
$ git pr show -t 14087

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14087.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9111bb41)

[vicente-romero-oracle]

lgtm

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307814: In the case of two methods with Record Patterns, the second one contains a line number from the first method

Reviewed-by: vromero, godin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 8474e69: 8308465: Reduce memory accesses in AArch64 MD5 intrinsic
• f99ad11: 8302218: CHeapBitMap::free frees with incorrect size
• d77a410: 8308388: Update description of SourceVersion.RELEASE_21
• 3f4cfbd: 8307190: Refactor ref_at methods in Constant Pool
• 491bdea: 8308458: Windows build failure with disassembler.cpp(792): warning C4267: '=': conversion from 'size_t' to 'int'
• b58980b: 8308034: Some CDS tests need to use @requires vm.flagless
• 29b8d3d: 8307573: Implementation of JEP 449: Deprecate the Windows 32-bit x86 Port for Removal
• 5fc9b57: 8308276: Change layout API to work with bytes, not bits
• 91aeb5d: 8287834: Add SymbolLookup::or method
• 4f88437: 8307908: [ppc] Add failing RTM tests to ProblemList until 8307907 is fixed.
• ... and 11 more: https://git.openjdk.org/jdk/compare/41beb448d2ac5d432558f25362a787a9511a5d83...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit 1cfb265.
Since your change was applied there have been 36 commits pushed to the master branch:

• eb11508: 8308281: Java snippets in the FFM API need to be updated
• 26227a6: 8305073: Fix VerifyLoopOptimizations - step 2 - verify idom
• 80d7de7: 8305582: Compiler crash when compiling record patterns with var
• e559613: 8308500: ZStatSubPhase::register_start should not call register_gc_phase_start if ZAbort::should_abort()
• bdd2402: 8260943: C2 SuperWord: Remove dead vectorization optimization added by 8076284
• 4f0f776: 8308403: [s390x] separate remaining_cargs from z_abi_160
• 06b0a5e: 8302652: [SuperWord] Reduction should happen after loop, when possible
• 69f508a: 8308300: enhance exceptions in MappedMemoryUtils.c
• c440827: 8308093: Disable language preview features use in JDK
• 422128b: 8306992: [JVMCI] mitigate more against JVMCI related OOME causing VM to exit
• ... and 26 more: https://git.openjdk.org/jdk/compare/41beb448d2ac5d432558f25362a787a9511a5d83...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 1cfb265.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.