Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256949: Shenandoah: ditch allocation spike and GC penalties handling #1409

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Nov 24, 2020

Following the improvements in JDK-8255984, I think we can dispense with old-style allocation spike and GC penalties handling. JDK-8255984 is supposed to accommodate both cases now. This issue is to have a base for performance evaluation.

Additional testing:

  • Linux x86_64 hotspot_gc_shenandoah

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux aarch64 Linux arm Linux ppc64le Linux s390x Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (1/1 passed) (1/1 failed) (1/1 failed) ✔️ (1/1 passed) ✔️ (6/6 passed) (2/2 failed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) (1/9 failed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test tasks

Issue

  • JDK-8256949: Shenandoah: ditch allocation spike and GC penalties handling

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1409/head:pull/1409
$ git checkout pull/1409

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 24, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 24, 2020

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc shenandoah labels Nov 24, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 24, 2020

Webrevs

@earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Nov 24, 2020

Might I suggest we instead lower the defaults but keep this safety net as an available option? Maybe remove the penalties, but keep the ShenandoahAllocSpikeFactor?

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 22, 2020

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 19, 2021

@shipilev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it!

@bridgekeeper bridgekeeper bot closed this Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc rfr shenandoah
2 participants