Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8230652: Improve verbose output #141

Closed
wants to merge 1 commit into from

Conversation

@andyherrick
Copy link

@andyherrick andyherrick commented Sep 12, 2020

JDK-8230652
Extracting the commands displayed by verbose output (including commands called thru ToolProvider) , to contain the the command, it's output, and it's return value on separate lines and formatted in a way that they can be easily cut and pasted into a script.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/141/head:pull/141
$ git checkout pull/141

@andyherrick andyherrick marked this pull request as ready for review Sep 12, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 12, 2020

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 12, 2020

@andyherrick The following label will be automatically applied to this pull request: core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the core-libs label Sep 12, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 12, 2020

Webrevs

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Sep 14, 2020

Looks good

Copy link
Member

@sashamatveev sashamatveev left a comment

Looks good.

Copy link
Member

@azuev-java azuev-java left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@andyherrick This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8230652: Improve verbose output

Reviewed-by: almatvee, asemenyuk, kizune
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 101 commits pushed to the master branch:

  • 5a7390b: 8253418: ZGC: Use pd_ prefix to denote platform dependent code
  • 7e49eae: 8253407: Move max_pow2 from test to src
  • fbfb62d: 8253332: ZGC: Make heap views reservation platform independent
  • dad6edb: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode
  • edc14f9: 8253286: Use expand_exact() instead of expand_at() for fixed requests in G1
  • bba948f: 8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
  • 955c2e6: 8253303: G1: Move static initialization of G1FromCardCache to a proper location
  • 34ec1be: 8252104: parallel heap inspection for ShenandoahHeap
  • fdce055: 8253253: Binutils tar ball extension update to gz
  • 388c8f2: 8253348: Remove unimplemented JNIHandles::initialize
  • ... and 91 more: https://git.openjdk.java.net/jdk/compare/952518640a50ce86ca6f295867cfde93f6ac8b26...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 5a7390b62a71d1ccc279ef6738ea57387e397b0b.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 21, 2020
@andyherrick
Copy link
Author

@andyherrick andyherrick commented Sep 21, 2020

/integrate

@openjdk openjdk bot closed this Sep 21, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@andyherrick Since your change was applied there have been 101 commits pushed to the master branch:

  • 5a7390b: 8253418: ZGC: Use pd_ prefix to denote platform dependent code
  • 7e49eae: 8253407: Move max_pow2 from test to src
  • fbfb62d: 8253332: ZGC: Make heap views reservation platform independent
  • dad6edb: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode
  • edc14f9: 8253286: Use expand_exact() instead of expand_at() for fixed requests in G1
  • bba948f: 8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
  • 955c2e6: 8253303: G1: Move static initialization of G1FromCardCache to a proper location
  • 34ec1be: 8252104: parallel heap inspection for ShenandoahHeap
  • fdce055: 8253253: Binutils tar ball extension update to gz
  • 388c8f2: 8253348: Remove unimplemented JNIHandles::initialize
  • ... and 91 more: https://git.openjdk.java.net/jdk/compare/952518640a50ce86ca6f295867cfde93f6ac8b26...master

Your commit was automatically rebased without conflicts.

Pushed as commit 43be5a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andyherrick andyherrick deleted the bugfix-8230652 branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants