Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306703: JFR: Summary views #14104

Closed
wants to merge 5 commits into from
Closed

8306703: JFR: Summary views #14104

wants to merge 5 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented May 23, 2023

Could I have a review of an enhancement that adds a view command to jfr.

Testing: tier1, tier2 + jdk/jdk/jfr

For the change to work properly when streaming, fix of 8307738 needs to be applied.

To simplify the review, changes not relevant to the feature, but that can use classes in jdk.jfr.internal.util package, will be refactored after this change has been integrated. Possibly in JDK 22.

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8306704 to be approved

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14104/head:pull/14104
$ git checkout pull/14104

Update a local copy of the PR:
$ git checkout pull/14104
$ git pull https://git.openjdk.org/jdk.git pull/14104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14104

View PR using the GUI difftool:
$ git pr show -t 14104

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14104.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2023

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2023

@egahlin The following labels will be automatically applied to this pull request:

  • build
  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org labels May 23, 2023
@egahlin egahlin marked this pull request as ready for review May 23, 2023 16:51
@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2023
@mlbridge
Copy link

mlbridge bot commented May 23, 2023

Webrevs

@egahlin egahlin marked this pull request as draft May 23, 2023 23:57
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 23, 2023
@egahlin egahlin marked this pull request as ready for review May 24, 2023 13:38
@openjdk openjdk bot added the rfr Pull request is ready for review label May 24, 2023
Copy link

@mgronlun mgronlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work, Erik! It is going to help folks better focus to understand what is important and the extension capabilities are numerous. Thank you very much!

@openjdk
Copy link

openjdk bot commented May 25, 2023

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306703: JFR: Summary views

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 377 new commits pushed to the master branch:

  • 90e57fd: 8308335: JFR: Remove @experimental from Virtual Threads events
  • 7e2e05d: 8308098: G1: Remove redundant checks in G1ObjectCountIsAliveClosure
  • 2599ada: 8308655: Narrow types of ConstantPool and ConstMethod returns
  • 5a0a238: 8308746: C2 IR test failures for TestFpMinMaxReductions.java with SSE2
  • 38367d3: 8308735: Typos in parameter names
  • 4f096eb: 8305635: Replace Parse Predicate IfNode with new ParsePredicateNode and route predicate queries through dedicated classes
  • f27bc59: 8307132: Cleanup the code of sun.java2d.cmm.lcms package
  • 426ebf4: 8308475: Make the thread dump files generated by jcmd Thread.dump_to_file jtreg failure handler action easily accessible
  • 8d8153e: 8307958: Metaspace verification is slow causing extreme class unloading times
  • d877134: 8144891: ToolBox should use java.nio.file.Path internally, instead of java.io.File
  • ... and 367 more: https://git.openjdk.org/jdk/compare/1532a1b0bd72f37b77540af51368271ef80e17d2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 25, 2023
@egahlin
Copy link
Member Author

egahlin commented May 25, 2023

This is great work, Erik! It is going to help folks better focus to understand what is important and the extension capabilities are numerous. Thank you very much!

Thanks for the review! It was a lot to go through.

@egahlin
Copy link
Member Author

egahlin commented May 25, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 25, 2023

Going to push as commit 98acce1.
Since your change was applied there have been 380 commits pushed to the master branch:

  • 534de6d: 8300491: SymbolLookup::libraryLookup accepts strings with terminators
  • 48d21bd: 8286597: Implement PollerProvider on AIX
  • e7edf8d: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters
  • 90e57fd: 8308335: JFR: Remove @experimental from Virtual Threads events
  • 7e2e05d: 8308098: G1: Remove redundant checks in G1ObjectCountIsAliveClosure
  • 2599ada: 8308655: Narrow types of ConstantPool and ConstMethod returns
  • 5a0a238: 8308746: C2 IR test failures for TestFpMinMaxReductions.java with SSE2
  • 38367d3: 8308735: Typos in parameter names
  • 4f096eb: 8305635: Replace Parse Predicate IfNode with new ParsePredicateNode and route predicate queries through dedicated classes
  • f27bc59: 8307132: Cleanup the code of sun.java2d.cmm.lcms package
  • ... and 370 more: https://git.openjdk.org/jdk/compare/1532a1b0bd72f37b77540af51368271ef80e17d2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2023
@openjdk openjdk bot closed this May 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@egahlin Pushed as commit 98acce1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
3 participants