Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297887: Update Siphash #14124

Closed
wants to merge 1 commit into from
Closed

8297887: Update Siphash #14124

wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented May 24, 2023

There was a small update to the copyright in the SipHash code that we're using, so reflecting that change in our sources.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14124/head:pull/14124
$ git checkout pull/14124

Update a local copy of the PR:
$ git checkout pull/14124
$ git pull https://git.openjdk.org/jdk.git pull/14124/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14124

View PR using the GUI difftool:
$ git pr show -t 14124

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14124.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2023

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 24, 2023
@mlbridge
Copy link

mlbridge bot commented May 24, 2023

Webrevs

Copy link
Member

@lfoltan lfoltan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented May 24, 2023

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297887: Update Siphash

Reviewed-by: lfoltan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 7764f46: 8308761: New test TestHFA needs adaptation for JDK-8308276
  • d7245f7: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions
  • 544978c: 8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out
  • 65c8dbe: 8171221: Remove -XX:+CheckMemoryInitialization
  • 2d4d850: 8308091: Remove unused iRegIHeapbase() matching operand
  • b7a84b0: 8308758: Problemlist compiler/c2/irTests/TestVectorConditionalMove.java
  • 20f1535: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview)
  • 466ec30: 8302736: Major performance regression in Math.log on aarch64
  • 05c095c: 8308151: [JVMCI] capture JVMCI exceptions in hs-err
  • beb75e6: 8306302: C2 Superword fix: use VectorMaskCmp and VectorBlend instead of CMoveVF/D
  • ... and 7 more: https://git.openjdk.org/jdk/compare/e9320f31dcc4ff5197e8c3bca504a7d5c1a9035e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 24, 2023
@coleenp
Copy link
Contributor Author

coleenp commented May 24, 2023

Thanks Lois!
/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2023

Going to push as commit bacf652.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 89f2d45: 8308237: add JDWP and JDI virtual thread support for ThreadReference.PopFrames
  • d10467e: 8307738: JFR: EventStream.openRepository() drops events
  • 736b90d: 8308310: HttpClient: Avoid logging or locking from within synchronized blocks
  • 7764f46: 8308761: New test TestHFA needs adaptation for JDK-8308276
  • d7245f7: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions
  • 544978c: 8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out
  • 65c8dbe: 8171221: Remove -XX:+CheckMemoryInitialization
  • 2d4d850: 8308091: Remove unused iRegIHeapbase() matching operand
  • b7a84b0: 8308758: Problemlist compiler/c2/irTests/TestVectorConditionalMove.java
  • 20f1535: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview)
  • ... and 10 more: https://git.openjdk.org/jdk/compare/e9320f31dcc4ff5197e8c3bca504a7d5c1a9035e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2023
@openjdk openjdk bot closed this May 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

@coleenp Pushed as commit bacf652.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the siphash branch June 2, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants