8308073: ClassLoaderExt::append_boot_classpath should handle dynamic archive

[calvinccheung]

Please review this simple fix for setting the _has_platform_or_app_classes flag for the dynamic archive case. The flag will be set to false in case the boot class path is appended via JVM TI.
Also adjusting two related JvmtiAddPath.java tests accordingly.

Passed tiers 1 - 4 testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308073: ClassLoaderExt::append_boot_classpath should handle dynamic archive

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Matias Saavedra Silva (@matias9927 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14127/head:pull/14127
$ git checkout pull/14127

Update a local copy of the PR:
$ git checkout pull/14127
$ git pull https://git.openjdk.org/jdk.git pull/14127/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14127

View PR using the GUI difftool:
$ git pr show -t 14127

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14127.diff

Webrev

Link to Webrev Comment

[calvinccheung]

/label add hotspot-runtime

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (74275802)

[iklam]

LGTM. Thanks for fixing this.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308073: ClassLoaderExt::append_boot_classpath should handle dynamic archive

Reviewed-by: iklam, matsaave

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

• 7d2a7ce: 8308672: Add version number in the replay file generated by DumpInline
• 27ba8bd: 8308108: Support Unicode extension for collation settings
• 89b3c37: 8307125: compiler/jvmci/compilerToVM/MaterializeVirtualObjectTest.java hits assert(!Continuation::is_frame_in_continuation(thread(), fr())) failed: No support for deferred values in continuations
• 98acce1: 8306703: JFR: Summary views
• 534de6d: 8300491: SymbolLookup::libraryLookup accepts strings with terminators
• 48d21bd: 8286597: Implement PollerProvider on AIX
• e7edf8d: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters
• 90e57fd: 8308335: JFR: Remove @experimental from Virtual Threads events
• 7e2e05d: 8308098: G1: Remove redundant checks in G1ObjectCountIsAliveClosure
• 2599ada: 8308655: Narrow types of ConstantPool and ConstMethod returns
• ... and 62 more: https://git.openjdk.org/jdk/compare/8474e693b4404ba62927fe0e43e68b904d66fbde...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[matias9927]

LGTM!

[calvinccheung]

Thanks @iklam and @matias9927 for the review.
/integrate

[openjdk]

Going to push as commit dc7683a.
Since your change was applied there have been 73 commits pushed to the master branch:

• 4870234: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false"
• 7d2a7ce: 8308672: Add version number in the replay file generated by DumpInline
• 27ba8bd: 8308108: Support Unicode extension for collation settings
• 89b3c37: 8307125: compiler/jvmci/compilerToVM/MaterializeVirtualObjectTest.java hits assert(!Continuation::is_frame_in_continuation(thread(), fr())) failed: No support for deferred values in continuations
• 98acce1: 8306703: JFR: Summary views
• 534de6d: 8300491: SymbolLookup::libraryLookup accepts strings with terminators
• 48d21bd: 8286597: Implement PollerProvider on AIX
• e7edf8d: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters
• 90e57fd: 8308335: JFR: Remove @experimental from Virtual Threads events
• 7e2e05d: 8308098: G1: Remove redundant checks in G1ObjectCountIsAliveClosure
• ... and 63 more: https://git.openjdk.org/jdk/compare/8474e693b4404ba62927fe0e43e68b904d66fbde...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit dc7683a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.