8308727: Compiler should accept final unnamed variables in try-with-resources

[biboudis]

This PR addresses the bug with final but also with annotations on local variables within try-with-resources.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308727: Compiler should accept final unnamed variables in try-with-resources

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14130/head:pull/14130
$ git checkout pull/14130

Update a local copy of the PR:
$ git checkout pull/14130
$ git pull https://git.openjdk.org/jdk.git pull/14130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14130

View PR using the GUI difftool:
$ git pr show -t 14130

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14130.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@biboudis The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0422855e)

[lahodaj]

Seems reasonable to me.

[openjdk]

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308727: Compiler should accept final unnamed variables in try-with-resources

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• b44fa36: 8308040: Evaluate new public types in non-public classes
• ac89e30: 8308291: compiler/jvmci/meta/ProfilingInfoTest.java fails with -XX:TieredStopAtLevel=1
• bacf652: 8297887: Update Siphash
• 89f2d45: 8308237: add JDWP and JDI virtual thread support for ThreadReference.PopFrames
• d10467e: 8307738: JFR: EventStream.openRepository() drops events
• 736b90d: 8308310: HttpClient: Avoid logging or locking from within synchronized blocks
• 7764f46: 8308761: New test TestHFA needs adaptation for JDK-8308276
• d7245f7: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions
• 544978c: 8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out
• 65c8dbe: 8171221: Remove -XX:+CheckMemoryInitialization
• ... and 6 more: https://git.openjdk.org/jdk/compare/2836c34b64e4626e25c86a53e5bef2bf32f95d2e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lahodaj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[biboudis]

/integrate

[openjdk]

@biboudis
Your change (at version 0422855) is now ready to be sponsored by a Committer.

[lahodaj]

/sponsor

[openjdk]

Going to push as commit 4500bb7.
Since your change was applied there have been 24 commits pushed to the master branch:

• 3272e25: 8305710: Line breaks in search tags cause invalid JSON in index file
• 3f4abff: 8305958: Use links instead of buttons for auto-generated header links
• bfcae68: 8308549: Classfile API should fail to generate over-sized Code attribute
• 2a18e53: 8308656: RISC-V: vstring_compare doesnt manifest usage of all vector registers
• a291f00: 8288619: Unexpected parsing for @see
• 89b9914: 8308400: add ForceEarlyReturn support for virtual threads
• 1451ac1: 8307652: sealed class hierarchy graph doesn't distinguish non-sealed classes
• 207fbcb: 8299414: JVMTI FollowReferences should support references from VirtualThread stack
• b44fa36: 8308040: Evaluate new public types in non-public classes
• ac89e30: 8308291: compiler/jvmci/meta/ProfilingInfoTest.java fails with -XX:TieredStopAtLevel=1
• ... and 14 more: https://git.openjdk.org/jdk/compare/2836c34b64e4626e25c86a53e5bef2bf32f95d2e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj @biboudis Pushed as commit 4500bb7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.