Skip to content

Conversation

@ashu-mehra
Copy link
Contributor

@ashu-mehra ashu-mehra commented May 24, 2023

Please review this PR that adds version to the replay file generated by DumpInline.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308672: Add version number in the replay file generated by DumpInline

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14131/head:pull/14131
$ git checkout pull/14131

Update a local copy of the PR:
$ git checkout pull/14131
$ git pull https://git.openjdk.org/jdk.git pull/14131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14131

View PR using the GUI difftool:
$ git pr show -t 14131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14131.diff

Webrev

Link to Webrev Comment

Signed-off-by: Ashutosh Mehra <asmehra@redhat.com>
@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2023

👋 Welcome back ashu-mehra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

@ashu-mehra The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 24, 2023
@mlbridge
Copy link

mlbridge bot commented May 24, 2023

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented May 24, 2023

@ashu-mehra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308672: Add version number in the replay file generated by DumpInline

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 1451ac1: 8307652: sealed class hierarchy graph doesn't distinguish non-sealed classes
  • 207fbcb: 8299414: JVMTI FollowReferences should support references from VirtualThread stack
  • b44fa36: 8308040: Evaluate new public types in non-public classes
  • ac89e30: 8308291: compiler/jvmci/meta/ProfilingInfoTest.java fails with -XX:TieredStopAtLevel=1
  • bacf652: 8297887: Update Siphash
  • 89f2d45: 8308237: add JDWP and JDI virtual thread support for ThreadReference.PopFrames
  • d10467e: 8307738: JFR: EventStream.openRepository() drops events
  • 736b90d: 8308310: HttpClient: Avoid logging or locking from within synchronized blocks
  • 7764f46: 8308761: New test TestHFA needs adaptation for JDK-8308276
  • d7245f7: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions
  • ... and 19 more: https://git.openjdk.org/jdk/compare/9e196b3631af0156ce9958a2f631894968211a4c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 24, 2023
@ashu-mehra
Copy link
Contributor Author

@vnkozlov thanks for reviewing.

@ashu-mehra
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

@ashu-mehra
Your change (at version dfc6204) is now ready to be sponsored by a Committer.

@ashu-mehra
Copy link
Contributor Author

@vnkozlov would you please sponsor it as well?

@vnkozlov
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 25, 2023

Going to push as commit 7d2a7ce.
Since your change was applied there have been 53 commits pushed to the master branch:

  • 27ba8bd: 8308108: Support Unicode extension for collation settings
  • 89b3c37: 8307125: compiler/jvmci/compilerToVM/MaterializeVirtualObjectTest.java hits assert(!Continuation::is_frame_in_continuation(thread(), fr())) failed: No support for deferred values in continuations
  • 98acce1: 8306703: JFR: Summary views
  • 534de6d: 8300491: SymbolLookup::libraryLookup accepts strings with terminators
  • 48d21bd: 8286597: Implement PollerProvider on AIX
  • e7edf8d: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters
  • 90e57fd: 8308335: JFR: Remove @experimental from Virtual Threads events
  • 7e2e05d: 8308098: G1: Remove redundant checks in G1ObjectCountIsAliveClosure
  • 2599ada: 8308655: Narrow types of ConstantPool and ConstMethod returns
  • 5a0a238: 8308746: C2 IR test failures for TestFpMinMaxReductions.java with SSE2
  • ... and 43 more: https://git.openjdk.org/jdk/compare/9e196b3631af0156ce9958a2f631894968211a4c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2023
@openjdk openjdk bot closed this May 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@vnkozlov @ashu-mehra Pushed as commit 7d2a7ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ashu-mehra ashu-mehra deleted the JDK-8308672 branch August 4, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants