Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308801: update for deprecated sprintf for libnet in java.base #14132

Closed
wants to merge 1 commit into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented May 24, 2023

Hi,

May I have this update reviewed?

The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of security concerns. The issue was addressed in JDK-8296812 for building failure, and JDK-8299378/JDK-8299635/JDK-8301132 for testing issues . This is a break-down update for sprintf uses in libnet in the java.base module.

Thanks,
Xuelei


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308801: update for deprecated sprintf for libnet in java.base

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14132/head:pull/14132
$ git checkout pull/14132

Update a local copy of the PR:
$ git checkout pull/14132
$ git pull https://git.openjdk.org/jdk.git pull/14132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14132

View PR using the GUI difftool:
$ git pr show -t 14132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14132.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2023

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 24, 2023

@XueleiFan The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label May 24, 2023
@XueleiFan XueleiFan marked this pull request as ready for review May 24, 2023 19:10
@openjdk openjdk bot added the rfr Pull request is ready for review label May 24, 2023
@mlbridge
Copy link

mlbridge bot commented May 24, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 26, 2023

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308801: update for deprecated sprintf for libnet in java.base

Reviewed-by: djelinski, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • cc0976b: 8308589: gc/cslocker/TestCSLocker.java timed out
  • 17ef8a4: 8299665: /proc/self/stat parsing in libmanagement broken by execname with spaces
  • c494770: 8306812: Open source several AWT Miscellaneous tests
  • d3b9b36: 8308009: Generational ZGC: OOM before clearing all SoftReferences
  • bac02b6: 8305189: C2 failed "assert(_outcnt==1) failed: not unique"
  • 62537d2: 8299974: Replace NULL with nullptr in share/adlc/
  • f09345b: 8308931: Problemlist compiler/jvmci/TestUncaughtErrorInCompileMethod.java
  • 7c072db: 8308844: ProblemList gc/z/TestHighUsage.java with Generational ZGC on windows x64
  • 4becb7b: 8306137: Open source several AWT ScrollPane related tests
  • 199b1bf: 8308583: SIGSEGV in GraphKit::gen_checkcast
  • ... and 32 more: https://git.openjdk.org/jdk/compare/ac89e3045b653969dfce48a2b34fd37078a2b958...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 26, 2023
@XueleiFan
Copy link
Member Author

Thank you for the review, @djelinski @RogerRiggs !

@XueleiFan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 26, 2023

Going to push as commit c72b547.
Since your change was applied there have been 44 commits pushed to the master branch:

  • 77c5adb: 8308935: jdk.management.jfr.RecordingInfo.toString() lacks test coverage
  • ce5251a: 8308657: ReplayInline is not availabe in production build
  • cc0976b: 8308589: gc/cslocker/TestCSLocker.java timed out
  • 17ef8a4: 8299665: /proc/self/stat parsing in libmanagement broken by execname with spaces
  • c494770: 8306812: Open source several AWT Miscellaneous tests
  • d3b9b36: 8308009: Generational ZGC: OOM before clearing all SoftReferences
  • bac02b6: 8305189: C2 failed "assert(_outcnt==1) failed: not unique"
  • 62537d2: 8299974: Replace NULL with nullptr in share/adlc/
  • f09345b: 8308931: Problemlist compiler/jvmci/TestUncaughtErrorInCompileMethod.java
  • 7c072db: 8308844: ProblemList gc/z/TestHighUsage.java with Generational ZGC on windows x64
  • ... and 34 more: https://git.openjdk.org/jdk/compare/ac89e3045b653969dfce48a2b34fd37078a2b958...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 26, 2023
@openjdk openjdk bot closed this May 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 26, 2023
@openjdk
Copy link

openjdk bot commented May 26, 2023

@XueleiFan Pushed as commit c72b547.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8308801 branch May 26, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants