-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8308801: update for deprecated sprintf for libnet in java.base #14132
Conversation
👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into |
@XueleiFan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@XueleiFan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thank you for the review, @djelinski @RogerRiggs ! |
/integrate |
Going to push as commit c72b547.
Your commit was automatically rebased without conflicts. |
@XueleiFan Pushed as commit c72b547. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
May I have this update reviewed?
The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of security concerns. The issue was addressed in JDK-8296812 for building failure, and JDK-8299378/JDK-8299635/JDK-8301132 for testing issues . This is a break-down update for sprintf uses in libnet in the java.base module.
Thanks,
Xuelei
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14132/head:pull/14132
$ git checkout pull/14132
Update a local copy of the PR:
$ git checkout pull/14132
$ git pull https://git.openjdk.org/jdk.git pull/14132/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14132
View PR using the GUI difftool:
$ git pr show -t 14132
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14132.diff
Webrev
Link to Webrev Comment