8308876 JFR: Deserialization of EventTypeInfo uses incorrect attribute names

[egahlin]

Could I have a review of a bug when deserialzing EventTypeInfo. For details, see CSR.

Testing: test/jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8308877 to be approved

Issues

• JDK-8308876: JFR: Deserialization of EventTypeInfo uses incorrect attribute names
• JDK-8308877: JFR: Deserialization of EventTypeInfo uses incorrect attribute names (CSR)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14155/head:pull/14155
$ git checkout pull/14155

Update a local copy of the PR:
$ git checkout pull/14155
$ git pull https://git.openjdk.org/jdk.git pull/14155/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14155

View PR using the GUI difftool:
$ git pr show -t 14155

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14155.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1dcbbb18)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308876: JFR: Deserialization of EventTypeInfo uses incorrect attribute names

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• a923634: 8286470: Support searching for sections in class/package javadoc
• 55d297f: 8308594: Use atomic bitset function for PackageEntry::_defined_by_cds_in_class_path
• c72b547: 8308801: update for deprecated sprintf for libnet in java.base
• 77c5adb: 8308935: jdk.management.jfr.RecordingInfo.toString() lacks test coverage
• ce5251a: 8308657: ReplayInline is not availabe in production build
• cc0976b: 8308589: gc/cslocker/TestCSLocker.java timed out
• 17ef8a4: 8299665: /proc/self/stat parsing in libmanagement broken by execname with spaces
• c494770: 8306812: Open source several AWT Miscellaneous tests
• d3b9b36: 8308009: Generational ZGC: OOM before clearing all SoftReferences
• bac02b6: 8305189: C2 failed "assert(_outcnt==1) failed: not unique"
• ... and 16 more: https://git.openjdk.org/jdk/compare/90e57fd5a96199b01e7c058a4d8a82e467d7f41a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit 5fdb22f.
Since your change was applied there have been 27 commits pushed to the master branch:

• bd113ee: 8308814: extend SetLocalXXX minimal support for virtual threads
• a923634: 8286470: Support searching for sections in class/package javadoc
• 55d297f: 8308594: Use atomic bitset function for PackageEntry::_defined_by_cds_in_class_path
• c72b547: 8308801: update for deprecated sprintf for libnet in java.base
• 77c5adb: 8308935: jdk.management.jfr.RecordingInfo.toString() lacks test coverage
• ce5251a: 8308657: ReplayInline is not availabe in production build
• cc0976b: 8308589: gc/cslocker/TestCSLocker.java timed out
• 17ef8a4: 8299665: /proc/self/stat parsing in libmanagement broken by execname with spaces
• c494770: 8306812: Open source several AWT Miscellaneous tests
• d3b9b36: 8308009: Generational ZGC: OOM before clearing all SoftReferences
• ... and 17 more: https://git.openjdk.org/jdk/compare/90e57fd5a96199b01e7c058a4d8a82e467d7f41a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 5fdb22f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.