Skip to content

8257516: define test group for manual tests #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

frkator
Copy link
Member

@frkator frkator commented Nov 24, 2020

Defined new test groups as defined in ticket. @fguallini


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1416/head:pull/1416
$ git checkout pull/1416

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2020

👋 Welcome back isipka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 24, 2020
@openjdk
Copy link

openjdk bot commented Nov 25, 2020

@frkator The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 25, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2020

Webrevs

@frkator
Copy link
Member Author

frkator commented Nov 27, 2020

/label rfr

@openjdk
Copy link

openjdk bot commented Nov 27, 2020

@frkator The label rfr is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

Copy link
Member

@iignatev iignatev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frkator, you will need to open a new JBS ticket for this change.

@frkator
Copy link
Member Author

frkator commented Dec 2, 2020

/test builds

@openjdk
Copy link

openjdk bot commented Dec 2, 2020

@frkator you need to get approval to run the tests in builds for commits up until c91558be

@openjdk openjdk bot added the test-request label Dec 2, 2020
@frkator
Copy link
Member Author

frkator commented Dec 2, 2020

@iignatev as for:
"#1416 (comment)"
accidentaly resolved. Yes they are but the goal is to list all manual tests under one label for counting purposes.
Could you please assist with above?
I assume it was due to some intermittent issue, I was able to build on the failed ones.

@iignatev
Copy link
Member

iignatev commented Dec 2, 2020

@iignatev as for:
"#1416 (comment)"
accidentaly resolved. Yes they are but the goal is to list all manual tests under one label for counting purposes.

I understand that; my comment was rather to @AlanBateman 's request not to add manual tests into :jdk_code. they already are, and removing explicit inclusion of :jdk_core_manual to :jdk_core won't change that.

-- Igor

@frkator frkator changed the title 8256894: define test groups 8257516: define test group for manual tests Dec 4, 2020
Copy link
Member

@iignatev iignatev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Dec 5, 2020

@frkator This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257516: define test group for manual tests

Reviewed-by: iignatyev

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 247 new commits pushed to the master branch:

  • 1a9ed92: 8200102: NativeLibraryTest.java fails intermittently, unloaded count is not same as expected
  • 264feb3: 8257905: Make fixpath.sh more liberal in accepting paths embedded in arguments
  • 044616b: 8252049: Native memory leak in ciMethodData ctor
  • fab6158: 8236413: AbstractConnectTimeout should tolerate both NoRouteToHostException and UnresolvedAddressException
  • 936a7ac: 8252797: Non-PCH build fails on Ubuntu 16.4 when building with gtests
  • d0c5265: 8256149: Weird AST structure for incomplete member select
  • a708024: 8257194: Add 'foreign linker API' in 'jdk.incubator.foreign' module desc/summary
  • 35e8153: 8257848: -XX:CompileCommand=blackhole,* should be diagnostic
  • d2b6619: 8242258: (jrtfs) Path::toUri throws AssertionError for malformed input
  • 52ab721: 8254733: HotSpot Style Guide should permit using range-based for loops
  • ... and 237 more: https://git.openjdk.java.net/jdk/compare/ff6df15be3dc94b773093d86e42e0dd1da24d5a2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iignatev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2020
@frkator
Copy link
Member Author

frkator commented Dec 8, 2020

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 8, 2020
@openjdk
Copy link

openjdk bot commented Dec 8, 2020

@frkator
Your change (at version c47bb09) is now ready to be sponsored by a Committer.

@AlanBateman
Copy link
Contributor

/sponsor

@openjdk openjdk bot closed this Dec 9, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored labels Dec 9, 2020
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2020
@openjdk
Copy link

openjdk bot commented Dec 9, 2020

@AlanBateman @frkator Since your change was applied there have been 261 commits pushed to the master branch:

  • 5bdce9b: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record
  • b4615c6: 8256580: Fault in new grid display
  • df55ecd: 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32
  • fae7961: 8257884: Re-enable sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java as automatic test
  • 79f1dfb: 8255987: JDI tests fail with com.sun.jdi.ObjectCollectedException
  • 9ce3d80: 8257887: java/foreign/TestSegments.java test fails on 32-bit after JDK-8257186
  • 10da767: 8257847: Tiered should publish MDO data pointer for interpreter after profile start
  • 2a62d5d: 8256917: Use combo @returns tag in java.compiler javadoc
  • b29f9cd: 8075778: Add javadoc tag to avoid duplication of return information in simple situations.
  • 48d8650: 8257845: Integrate JEP 390
  • ... and 251 more: https://git.openjdk.java.net/jdk/compare/ff6df15be3dc94b773093d86e42e0dd1da24d5a2...master

Your commit was automatically rebased without conflicts.

Pushed as commit 616b1f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@frkator frkator deleted the code-changes branch December 9, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated test-request
Development

Successfully merging this pull request may close these issues.

3 participants