-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8257516: define test group for manual tests #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back isipka! A progress list of the required criteria for merging this PR into |
Webrevs
|
/label rfr |
@frkator The label
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frkator, you will need to open a new JBS ticket for this change.
/test builds |
@frkator you need to get approval to run the tests in builds for commits up until c91558be |
@iignatev as for: |
I understand that; my comment was rather to @AlanBateman 's request not to add manual tests into -- Igor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@frkator This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 247 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iignatev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@AlanBateman @frkator Since your change was applied there have been 261 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 616b1f1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Defined new test groups as defined in ticket. @fguallini
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1416/head:pull/1416
$ git checkout pull/1416