8308906: Make CIPrintCompilerName a diagnostic flag

[iklam]

Please review a very simple change. This makes it easy to see which JIT compiler is used to compile each method:

java -XX:+UnlockDiagnosticVMOptions -XX:+PrintCompilation -XX:+CIPrintCompilerName  -jar MyApp.java

CSR is not needed because this is a diagnostic VM option.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308906: Make CIPrintCompilerName a diagnostic flag

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14161/head:pull/14161
$ git checkout pull/14161

Update a local copy of the PR:
$ git checkout pull/14161
$ git pull https://git.openjdk.org/jdk.git pull/14161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14161

View PR using the GUI difftool:
$ git pr show -t 14161

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14161.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7a4b8fcf)
• 00: Full (86fbe398)

[vnkozlov]

Please, also fix name duplication in output:

C1:     79 C1:   1       3       java.lang.Object::<init> (1 bytes)

[vnkozlov]

UL output is correct (no duplication):

[0.055s][debug][jit,compilation] C1:   1       3       java.lang.Object::<init> (1 bytes)

[iklam]

Please, also fix name duplication in output:

C1:     79 C1:   1       3       java.lang.Object::<init> (1 bytes)

Fixed.

[tstuefe]

That is very useful.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308906: Make CIPrintCompilerName a diagnostic flag

Reviewed-by: kvn, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 165 new commits pushed to the master branch:

• ce5251a: 8308657: ReplayInline is not availabe in production build
• cc0976b: 8308589: gc/cslocker/TestCSLocker.java timed out
• 17ef8a4: 8299665: /proc/self/stat parsing in libmanagement broken by execname with spaces
• c494770: 8306812: Open source several AWT Miscellaneous tests
• d3b9b36: 8308009: Generational ZGC: OOM before clearing all SoftReferences
• bac02b6: 8305189: C2 failed "assert(_outcnt==1) failed: not unique"
• 62537d2: 8299974: Replace NULL with nullptr in share/adlc/
• f09345b: 8308931: Problemlist compiler/jvmci/TestUncaughtErrorInCompileMethod.java
• 7c072db: 8308844: ProblemList gc/z/TestHighUsage.java with Generational ZGC on windows x64
• 4becb7b: 8306137: Open source several AWT ScrollPane related tests
• ... and 155 more: https://git.openjdk.org/jdk/compare/cb8b8cdd6861a0843f3b1036155eac9f9afc432a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vnkozlov]

Looks good.

[iklam]

Thanks @vnkozlov and @tstuefe for the review.
/integrate

[openjdk]

Going to push as commit 7508d9f.
Since your change was applied there have been 180 commits pushed to the master branch:

• a4bae3a: 8309060: Compilation Error in javax/swing/event/FocusEventCauseTest.java
• d73fc70: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
• 7cf6eec: 8307488: Incorrect weight of the first ObjectAllocationSample JFR event
• a5d8d59: 8308930: [JVMCI] TestUncaughtErrorInCompileMethod times out
• 70130d3: 8306119: Many components respond to a mouse event by requesting focus without supplying the MOUSE_EVENT cause
• 6360b49: 8308948: Remove unimplemented ThreadLocalAllocBuffer::reset
• e21f865: 8308915: RISC-V: Improve temporary vector register usage avoiding the use of v0
• 547a8b4: 8306560: Add TOOLING.jsh load file
• ca54f4e: 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone)
• 5fdb22f: 8308876: JFR: Deserialization of EventTypeInfo uses incorrect attribute names
• ... and 170 more: https://git.openjdk.org/jdk/compare/cb8b8cdd6861a0843f3b1036155eac9f9afc432a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 7508d9f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.