Skip to content

8308907: ProblemList java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java on linux-x64 #14163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented May 25, 2023

Trivial fixes to ProblemList a few tests:
JDK-8308907 ProblemList java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java on linux-x64
JDK-8308908 ProblemList javax/sound/sampled/Clip/ClipIsRunningAfterStop.java on linux-x64
JDK-8308909 ProblemList sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java on linux-x64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8308907: ProblemList java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java on linux-x64
  • JDK-8308908: ProblemList javax/sound/sampled/Clip/ClipIsRunningAfterStop.java on linux-x64
  • JDK-8308909: ProblemList sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java on linux-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14163/head:pull/14163
$ git checkout pull/14163

Update a local copy of the PR:
$ git checkout pull/14163
$ git pull https://git.openjdk.org/jdk.git pull/14163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14163

View PR using the GUI difftool:
$ git pr show -t 14163

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14163.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add client

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8308907
/issue JDK-8308908
/issue JDK-8308909

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@dcubed-ojdk
The client label was successfully added.

@openjdk openjdk bot changed the title Jdk 8308907 8308907: ProblemList java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java on linux-x64 May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk
Copy link

openjdk bot commented May 25, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8308908: ProblemList javax/sound/sampled/Clip/ClipIsRunningAfterStop.java on linux-x64.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review May 25, 2023 21:28
@openjdk
Copy link

openjdk bot commented May 25, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8308909: ProblemList sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java on linux-x64.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308907: ProblemList java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java on linux-x64
8308908: ProblemList javax/sound/sampled/Clip/ClipIsRunningAfterStop.java on linux-x64
8308909: ProblemList sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java on linux-x64

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • dc7683a: 8308073: ClassLoaderExt::append_boot_classpath should handle dynamic archive
  • 4870234: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 25, 2023
@dcubed-ojdk
Copy link
Member Author

@vidmik - Thanks for the lightning fast review!

/integrate

@openjdk
Copy link

openjdk bot commented May 25, 2023

Going to push as commit ee321c7.
Since your change was applied there have been 2 commits pushed to the master branch:

  • dc7683a: 8308073: ClassLoaderExt::append_boot_classpath should handle dynamic archive
  • 4870234: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2023
@openjdk openjdk bot closed this May 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@dcubed-ojdk Pushed as commit ee321c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented May 25, 2023

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8308907 branch May 25, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants