8308930: [JVMCI] TestUncaughtErrorInCompileMethod times out

[dougxc]

This PR makes TestUncaughtErrorInCompileMethod more robust against HotSpot compilation scheduling variability which should prevent timeouts in this test.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308930: [JVMCI] TestUncaughtErrorInCompileMethod times out

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer) ⚠️ Review applies to 8faf2b2e

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14173/head:pull/14173
$ git checkout pull/14173

Update a local copy of the PR:
$ git checkout pull/14173
$ git pull https://git.openjdk.org/jdk.git pull/14173/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14173

View PR using the GUI difftool:
$ git pr show -t 14173

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14173.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (73c065e6)
• 01: Full - Incremental (8faf2b2e)
• 00: Full (5bea1aae)

[tkrodriguez]

This summing is weird since it's adding currentTimeMillis each time. Aren't you just trying to report how long it waited, which would just be end - start. Also having a sleep here so it isn't simply spinning wouldn't hurt.

[dougxc]

I'm not really trying to report anything related to timing. I just need this loop to do some work that triggers JVMCI compilation. I'm open to better suggestions.

[tkrodriguez]

A comment explaining that it's useless work to trigger a compilation would be help then. The work doesn't really matter.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308930: [JVMCI] TestUncaughtErrorInCompileMethod times out

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• a923634: 8286470: Support searching for sections in class/package javadoc
• 55d297f: 8308594: Use atomic bitset function for PackageEntry::_defined_by_cds_in_class_path
• c72b547: 8308801: update for deprecated sprintf for libnet in java.base
• 77c5adb: 8308935: jdk.management.jfr.RecordingInfo.toString() lacks test coverage
• ce5251a: 8308657: ReplayInline is not availabe in production build
• cc0976b: 8308589: gc/cslocker/TestCSLocker.java timed out
• 17ef8a4: 8299665: /proc/self/stat parsing in libmanagement broken by execname with spaces
• c494770: 8306812: Open source several AWT Miscellaneous tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

Thanks for the review Tom.

/integrate

[openjdk]

Going to push as commit a5d8d59.
Since your change was applied there have been 15 commits pushed to the master branch:

• 70130d3: 8306119: Many components respond to a mouse event by requesting focus without supplying the MOUSE_EVENT cause
• 6360b49: 8308948: Remove unimplemented ThreadLocalAllocBuffer::reset
• e21f865: 8308915: RISC-V: Improve temporary vector register usage avoiding the use of v0
• 547a8b4: 8306560: Add TOOLING.jsh load file
• ca54f4e: 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone)
• 5fdb22f: 8308876: JFR: Deserialization of EventTypeInfo uses incorrect attribute names
• bd113ee: 8308814: extend SetLocalXXX minimal support for virtual threads
• a923634: 8286470: Support searching for sections in class/package javadoc
• 55d297f: 8308594: Use atomic bitset function for PackageEntry::_defined_by_cds_in_class_path
• c72b547: 8308801: update for deprecated sprintf for libnet in java.base
• ... and 5 more: https://git.openjdk.org/jdk/compare/d3b9b364da8c11c9b4dd14a6451a7b24f41202e7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit a5d8d59.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[TobiHartmann]

Unfortunately, the test still times out, see JDK-8309073.