Skip to content

8308948: Remove unimplemented ThreadLocalAllocBuffer::reset #14175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented May 26, 2023

Trivial removing dead code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308948: Remove unimplemented ThreadLocalAllocBuffer::reset

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14175/head:pull/14175
$ git checkout pull/14175

Update a local copy of the PR:
$ git checkout pull/14175
$ git pull https://git.openjdk.org/jdk.git pull/14175/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14175

View PR using the GUI difftool:
$ git pr show -t 14175

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14175.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 26, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8308948 8308948: Remove unimplemented ThreadLocalAllocBuffer::reset May 26, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label May 26, 2023
@openjdk
Copy link

openjdk bot commented May 26, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label May 26, 2023
@mlbridge
Copy link

mlbridge bot commented May 26, 2023

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and trivial.

@openjdk
Copy link

openjdk bot commented May 26, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308948: Remove unimplemented ThreadLocalAllocBuffer::reset

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 17ef8a4: 8299665: /proc/self/stat parsing in libmanagement broken by execname with spaces
  • c494770: 8306812: Open source several AWT Miscellaneous tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 26, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented May 29, 2023

Going to push as commit 6360b49.
Since your change was applied there have been 13 commits pushed to the master branch:

  • e21f865: 8308915: RISC-V: Improve temporary vector register usage avoiding the use of v0
  • 547a8b4: 8306560: Add TOOLING.jsh load file
  • ca54f4e: 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone)
  • 5fdb22f: 8308876: JFR: Deserialization of EventTypeInfo uses incorrect attribute names
  • bd113ee: 8308814: extend SetLocalXXX minimal support for virtual threads
  • a923634: 8286470: Support searching for sections in class/package javadoc
  • 55d297f: 8308594: Use atomic bitset function for PackageEntry::_defined_by_cds_in_class_path
  • c72b547: 8308801: update for deprecated sprintf for libnet in java.base
  • 77c5adb: 8308935: jdk.management.jfr.RecordingInfo.toString() lacks test coverage
  • ce5251a: 8308657: ReplayInline is not availabe in production build
  • ... and 3 more: https://git.openjdk.org/jdk/compare/d3b9b364da8c11c9b4dd14a6451a7b24f41202e7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 29, 2023
@openjdk openjdk bot closed this May 29, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 29, 2023
@openjdk
Copy link

openjdk bot commented May 29, 2023

@albertnetymk Pushed as commit 6360b49.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the tlab-trivial branch May 29, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants