Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308910: Allow executeAndLog to accept running process #14182

Closed
wants to merge 1 commit into from

Conversation

matias9927
Copy link
Contributor

@matias9927 matias9927 commented May 26, 2023

There may exist CDS test cases where it makes sense to call executeAndLog with a process after start() as been called. The method can simply be overloaded to take either a ProcessBuilder or a Process. Verified with tier 1-5 tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308910: Allow executeAndLog to accept running process

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14182/head:pull/14182
$ git checkout pull/14182

Update a local copy of the PR:
$ git checkout pull/14182
$ git pull https://git.openjdk.org/jdk.git pull/14182/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14182

View PR using the GUI difftool:
$ git pr show -t 14182

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14182.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 26, 2023

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 26, 2023

@matias9927 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 26, 2023
@matias9927 matias9927 marked this pull request as ready for review May 26, 2023 16:55
@openjdk openjdk bot added the rfr Pull request is ready for review label May 26, 2023
@mlbridge
Copy link

mlbridge bot commented May 26, 2023

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@openjdk
Copy link

openjdk bot commented May 26, 2023

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308910: Allow executeAndLog to accept running process

Reviewed-by: ccheung, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 198 new commits pushed to the master branch:

  • a923634: 8286470: Support searching for sections in class/package javadoc
  • 55d297f: 8308594: Use atomic bitset function for PackageEntry::_defined_by_cds_in_class_path
  • c72b547: 8308801: update for deprecated sprintf for libnet in java.base
  • 77c5adb: 8308935: jdk.management.jfr.RecordingInfo.toString() lacks test coverage
  • ce5251a: 8308657: ReplayInline is not availabe in production build
  • cc0976b: 8308589: gc/cslocker/TestCSLocker.java timed out
  • 17ef8a4: 8299665: /proc/self/stat parsing in libmanagement broken by execname with spaces
  • c494770: 8306812: Open source several AWT Miscellaneous tests
  • d3b9b36: 8308009: Generational ZGC: OOM before clearing all SoftReferences
  • bac02b6: 8305189: C2 failed "assert(_outcnt==1) failed: not unique"
  • ... and 188 more: https://git.openjdk.org/jdk/compare/97b2ca3de76046c6f52d3649d8787feea7b9ac83...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 26, 2023
Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matias9927
Copy link
Contributor Author

Thanks for the reviews @calvinccheung and @iklam
/integrate

@openjdk
Copy link

openjdk bot commented May 31, 2023

Going to push as commit 024d9b1.
Since your change was applied there have been 241 commits pushed to the master branch:

  • 25b9803: 8308917: C2 SuperWord::output: assert before bailout with CountedLoopReserveKit
  • d66b6d8: 8308765: RISC-V: Expand size of stub routines for zgc only
  • 4aea7da: 8309120: java/net/httpclient/AsyncShutdownNow.java fails intermittently
  • a990322: 8309111: Removing unused constructor of PerfLongCounter and PerfLongVariable
  • 4f3a95a: 8309054: Parsing of erroneous patterns succeeds
  • 4f16161: 8309044: Replace NULL with nullptr, final sweep of hotspot code
  • 8823626: 8309048: Remove malloc locker test case
  • 927a9ed: 8240774: [REDO] G1DirtyCardQueue destructor has useless flush
  • 119994f: 8308997: RISC-V: Sign extend when comparing 32-bit value with zero instead of testing the sign bit
  • 327733c: 8308986: Disable svc tests failing with virtual thread factory
  • ... and 231 more: https://git.openjdk.org/jdk/compare/97b2ca3de76046c6f52d3649d8787feea7b9ac83...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2023
@openjdk openjdk bot closed this May 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@matias9927 Pushed as commit 024d9b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants