Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303451: Synchronization entry in C2 debug info is misleading #14192

Closed
wants to merge 4 commits into from

Conversation

quadhier
Copy link
Contributor

@quadhier quadhier commented May 27, 2023

This should fix JDK-8303451.

It tries to correct some misleading code comments printed by -XX:+PrintAssembly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303451: Synchronization entry in C2 debug info is misleading (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14192/head:pull/14192
$ git checkout pull/14192

Update a local copy of the PR:
$ git checkout pull/14192
$ git pull https://git.openjdk.org/jdk.git pull/14192/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14192

View PR using the GUI difftool:
$ git pr show -t 14192

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14192.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2023

👋 Welcome back quadhier! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 27, 2023
@openjdk
Copy link

openjdk bot commented May 27, 2023

@quadhier The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 27, 2023
@mlbridge
Copy link

mlbridge bot commented May 27, 2023

Webrevs

@quadhier
Copy link
Contributor Author

Hi @TobiHartmann , could you please review this change? Thanks in advance!

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we detect if the method is synchronized and adjust the comment accordingly?

@TobiHartmann
Copy link
Member

@dean-long also had some suggestions in JDK-8201516 and might want to have a look.

@quadhier
Copy link
Contributor Author

Hi, @TobiHartmann thanks for your advice. It seems that this PR should do more than a simple change of code comment. I will investigate it further.

@quadhier
Copy link
Contributor Author

quadhier commented Jun 1, 2023

Thanks to your helpful discussions, the current change looks better but is still far from perfect.

I think UnwindBci is used in an exception-throwing case, but there seem to be no more appropriate bci used for the state "at method exit while not unlocked yet". I will continue looking into this.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2023

@quadhier This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2023

@quadhier This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review
2 participants