8309048: Remove malloc locker test case

[lkorinth]

There is a bunch of tests that are used to test critical section/gc locker. One of the test is named malloc. In that test, JNI code is doing a loop of malloc() followed sleep() followed by a free(). There is no JVM lock implementation to be tested on malloc/free. Let us save test time, code complexity and confusion by removing this test.

(Oracle) hs-tier5 testing passed on x86-64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309048: Remove malloc locker test case

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14201/head:pull/14201
$ git checkout pull/14201

Update a local copy of the PR:
$ git checkout pull/14201
$ git pull https://git.openjdk.org/jdk.git pull/14201/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14201

View PR using the GUI difftool:
$ git pr show -t 14201

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14201.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lkorinth The following labels will be automatically applied to this pull request:

• build
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a16642ee)

[lkorinth]

/label hotspot-gc

[openjdk]

@lkorinth
The hotspot-gc label was successfully added.

[dholmes-ora]

Looks fine. I couldn't find anything explaining the history of this test.

Thanks.

[openjdk]

@lkorinth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309048: Remove malloc locker test case

Reviewed-by: dholmes, tschatzl, coleenp, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• 927a9ed: 8240774: [REDO] G1DirtyCardQueue destructor has useless flush
• 119994f: 8308997: RISC-V: Sign extend when comparing 32-bit value with zero instead of testing the sign bit
• 327733c: 8308986: Disable svc tests failing with virtual thread factory
• 1e6770f: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM
• cb40db0: 8309134: Augment test/langtools/tools/javac/versions/Versions.java for JDK 21 language changes
• de7fd1c: 8307944: ClassFileDumper should only load java.nio.file.Path if enabled
• 7891de3: 8297885: misc sun/security/pkcs11 tests timed out
• 323d6ce: 8308960: Decouple internal Version and OperatingSystem classes
• 1b8e6bf: 8308987: Update java.lang.Class to use javadoc snippets
• 04b0e78: 8307648: java/net/httpclient/ExpectContinueTest.java timed out
• ... and 31 more: https://git.openjdk.org/jdk/compare/cc0976bf7fc41caa5abdaa23f4df00b1a5d5bfba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

This looks like a nice cleanup. I think we should migrate these tests into the tests/hotspot/gc directory and reconcile duplicates with other tests that do the same thing. This could be a future RFE/improvement.

[lkorinth]

Thanks David, Thomas, Coleen and Leonid! I am looking into further cleanups...

[lkorinth]

/integrate

[openjdk]

Going to push as commit 8823626.
Since your change was applied there have been 41 commits pushed to the master branch:

• 927a9ed: 8240774: [REDO] G1DirtyCardQueue destructor has useless flush
• 119994f: 8308997: RISC-V: Sign extend when comparing 32-bit value with zero instead of testing the sign bit
• 327733c: 8308986: Disable svc tests failing with virtual thread factory
• 1e6770f: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM
• cb40db0: 8309134: Augment test/langtools/tools/javac/versions/Versions.java for JDK 21 language changes
• de7fd1c: 8307944: ClassFileDumper should only load java.nio.file.Path if enabled
• 7891de3: 8297885: misc sun/security/pkcs11 tests timed out
• 323d6ce: 8308960: Decouple internal Version and OperatingSystem classes
• 1b8e6bf: 8308987: Update java.lang.Class to use javadoc snippets
• 04b0e78: 8307648: java/net/httpclient/ExpectContinueTest.java timed out
• ... and 31 more: https://git.openjdk.org/jdk/compare/cc0976bf7fc41caa5abdaa23f4df00b1a5d5bfba...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lkorinth Pushed as commit 8823626.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.