Skip to content

8308765: RISC-V: Expand size of stub routines for zgc only #14203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yadongw
Copy link
Contributor

@yadongw yadongw commented May 29, 2023

Size of stub routines is over expanded after https://bugs.openjdk.org/browse/JDK-8307058. It should return to a proper size, and only increase when zgc enabled on riscv, same as that on aarch64 and x86 port.
This PR also guarantees that li16u instructions can only accept 16 bits immediate values when patched or encoded.

The new size of stubs are tested with -XX:+UseZGC -XX:+ZGenerational -XX:-UseRVC, and checked with -Xlog:stubs.

Tier 1~3 passed on the unmatched boards.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308765: RISC-V: Expand size of stub routines for zgc only

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14203/head:pull/14203
$ git checkout pull/14203

Update a local copy of the PR:
$ git checkout pull/14203
$ git pull https://git.openjdk.org/jdk.git pull/14203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14203

View PR using the GUI difftool:
$ git pr show -t 14203

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14203.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 29, 2023

👋 Welcome back yadongwang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 29, 2023
@openjdk
Copy link

openjdk bot commented May 29, 2023

@yadongw The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label May 29, 2023
@mlbridge
Copy link

mlbridge bot commented May 29, 2023

Webrevs

@yadongw yadongw changed the title 8308765: RISC-V: Expand the size of stub routines when zgc only 8308765: RISC-V: Expand size of stub routines for zgc only May 30, 2023
Copy link
Member

@feilongjiang feilongjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented May 31, 2023

@yadongw This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308765: RISC-V: Expand size of stub routines for zgc only

Reviewed-by: fjiang, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 100 new commits pushed to the master branch:

  • 4aea7da: 8309120: java/net/httpclient/AsyncShutdownNow.java fails intermittently
  • a990322: 8309111: Removing unused constructor of PerfLongCounter and PerfLongVariable
  • 4f3a95a: 8309054: Parsing of erroneous patterns succeeds
  • 4f16161: 8309044: Replace NULL with nullptr, final sweep of hotspot code
  • 8823626: 8309048: Remove malloc locker test case
  • 927a9ed: 8240774: [REDO] G1DirtyCardQueue destructor has useless flush
  • 119994f: 8308997: RISC-V: Sign extend when comparing 32-bit value with zero instead of testing the sign bit
  • 327733c: 8308986: Disable svc tests failing with virtual thread factory
  • 1e6770f: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM
  • cb40db0: 8309134: Augment test/langtools/tools/javac/versions/Versions.java for JDK 21 language changes
  • ... and 90 more: https://git.openjdk.org/jdk/compare/466ec300fc8e5702553123cf2fa4b0d8c7d552d9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 31, 2023
@yadongw
Copy link
Contributor Author

yadongw commented May 31, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@yadongw
Your change (at version f4d40ec) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 31, 2023

Going to push as commit d66b6d8.
Since your change was applied there have been 100 commits pushed to the master branch:

  • 4aea7da: 8309120: java/net/httpclient/AsyncShutdownNow.java fails intermittently
  • a990322: 8309111: Removing unused constructor of PerfLongCounter and PerfLongVariable
  • 4f3a95a: 8309054: Parsing of erroneous patterns succeeds
  • 4f16161: 8309044: Replace NULL with nullptr, final sweep of hotspot code
  • 8823626: 8309048: Remove malloc locker test case
  • 927a9ed: 8240774: [REDO] G1DirtyCardQueue destructor has useless flush
  • 119994f: 8308997: RISC-V: Sign extend when comparing 32-bit value with zero instead of testing the sign bit
  • 327733c: 8308986: Disable svc tests failing with virtual thread factory
  • 1e6770f: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM
  • cb40db0: 8309134: Augment test/langtools/tools/javac/versions/Versions.java for JDK 21 language changes
  • ... and 90 more: https://git.openjdk.org/jdk/compare/466ec300fc8e5702553123cf2fa4b0d8c7d552d9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2023
@openjdk openjdk bot closed this May 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@RealFYang @yadongw Pushed as commit d66b6d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants