Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309060: Compilation Error in javax/swing/event/FocusEventCauseTest.java #14206

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented May 29, 2023

Inadvertent extraneous semicolon causing compilation error is fixed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309060: Compilation Error in javax/swing/event/FocusEventCauseTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14206/head:pull/14206
$ git checkout pull/14206

Update a local copy of the PR:
$ git checkout pull/14206
$ git pull https://git.openjdk.org/jdk.git pull/14206/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14206

View PR using the GUI difftool:
$ git pr show -t 14206

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14206.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 29, 2023

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 29, 2023
@openjdk
Copy link

openjdk bot commented May 29, 2023

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 29, 2023
@mlbridge
Copy link

mlbridge bot commented May 29, 2023

Webrevs

@prsadhuk
Copy link
Contributor Author

/integrate auto

@openjdk openjdk bot added the auto label May 29, 2023
@openjdk
Copy link

openjdk bot commented May 29, 2023

@prsadhuk This pull request will be automatically integrated when it is ready

Copy link
Contributor

@kumarabhi006 kumarabhi006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented May 29, 2023

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309060: Compilation Error in javax/swing/event/FocusEventCauseTest.java

Reviewed-by: abhiscxk, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 29, 2023
@openjdk
Copy link

openjdk bot commented May 29, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 29, 2023

Going to push as commit a4bae3a.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 29, 2023
@openjdk openjdk bot closed this May 29, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 29, 2023
@openjdk
Copy link

openjdk bot commented May 29, 2023

@openjdk[bot] Pushed as commit a4bae3a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the test-fix branch May 30, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants