-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8308152: PropertyDescriptor should work with overridden generic getter method #14228
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 151 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 73dd03c.
Your commit was automatically rebased without conflicts. |
Description of the bug, copied from #7190
Unfortunatly it was found that we have two code paths to create a PropertyDescriptor, one of them is used by the
Introspector.getBeanInfo
and was patched by the JDK-8196373 and another when the PropertyDescriptor is created directly and it still affected by that bug.The code added by this patch is the same we already use in PropertyInfo.java, see
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/com/sun/beans/introspect/PropertyInfo.java#L81
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14228/head:pull/14228
$ git checkout pull/14228
Update a local copy of the PR:
$ git checkout pull/14228
$ git pull https://git.openjdk.org/jdk.git pull/14228/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14228
View PR using the GUI difftool:
$ git pr show -t 14228
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14228.diff
Webrev
Link to Webrev Comment