Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308592: Framework for CA interoperability testing #14252

Closed
wants to merge 22 commits into from
Closed

8308592: Framework for CA interoperability testing #14252

wants to merge 22 commits into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented May 31, 2023

The new approach uses test URLs directly to verify interoperability with CA infrastructure. This would help us avoid having regular test fixes to update test artifacts as long as CAs keep test domains up to date.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308592: Framework for CA interoperability testing (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14252/head:pull/14252
$ git checkout pull/14252

Update a local copy of the PR:
$ git checkout pull/14252
$ git pull https://git.openjdk.org/jdk.git pull/14252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14252

View PR using the GUI difftool:
$ git pr show -t 14252

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14252.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 31, 2023

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 31, 2023

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 31, 2023
@rhalade rhalade marked this pull request as ready for review May 31, 2023 21:02
@openjdk openjdk bot added the rfr Pull request is ready for review label May 31, 2023
@rhalade rhalade changed the title 8308592: Update CA interop tests 8308592: Update CA interop test certificates May 31, 2023
@mlbridge
Copy link

mlbridge bot commented May 31, 2023

@wangweij
Copy link
Contributor

wangweij commented Jun 1, 2023

After this change, do all tests look exactly the same with only different URLs and CA alias names? If yes, can we just combine them into one test?

@rhalade
Copy link
Member Author

rhalade commented Jun 1, 2023

There are few minor differences but most of them will look the same. I kept tests separate so we can treat each CA differently and run / problem list at granular level. I will try to reduce the duplicate code further.

@seanjmullan
Copy link
Member

I suggest changing the title and description of the bug as the fix is more significant than updating a few expired certificates.

@rhalade rhalade changed the title 8308592: Update CA interop test certificates 8308592: Framework for CA interoperability testing Jun 1, 2023
@openjdk
Copy link

openjdk bot commented Jun 2, 2023

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308592: Framework for CA interoperability testing

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5308bbb: 8246280: Refine API to model sealed classes and interfaces in javax.lang.model

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 2, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2023

@rhalade This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2023

@rhalade This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Aug 11, 2023
@rhalade
Copy link
Member Author

rhalade commented Sep 15, 2023

/open

@openjdk openjdk bot reopened this Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@rhalade This pull request is now open

@@ -23,70 +23,13 @@

/*
* @test
* @bug 8245654 8314960
* @bug 8245654 8256895
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests for Certigna Root CA is moved to CAInterop but Certigna CA test will continue to use old framework as there are no test URLs.

This test is also update test for JDK-8256895 which was part of SSLCA.java test

@rhalade
Copy link
Member Author

rhalade commented Sep 19, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

Going to push as commit da57d2a.
Since your change was applied there have been 18 commits pushed to the master branch:

  • a6d120d: 8316513: Serial: Remove unused invalidate_remembered_set
  • 607bd4e: 8316294: AIX: Build fopen system call fails on file _BUILD_LIBJDWP_objectfilenames.txt
  • f25c920: 8314774: Optimize URLEncoder
  • 7c5f2a2: 8315669: Open source several Swing PopupMenu related tests
  • cf74b8c: 8316337: (bf) Concurrency issue in DirectByteBuffer.Deallocator
  • 4461eeb: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked
  • 670b456: 8315038: Capstone disassembler stops when it sees a bad instruction
  • fab372d: 8316428: G1: Nmethod count statistics only count last code root set iterated
  • 283c360: 8314877: Make fields final in 'java.net' package
  • 86115c2: 8316420: Serial: Remove unused GenCollectedHeap::oop_iterate
  • ... and 8 more: https://git.openjdk.org/jdk/compare/dcea9bf087c87548d9caa899c52e95d17478da22...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 19, 2023
@openjdk openjdk bot closed this Sep 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 19, 2023
@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@rhalade Pushed as commit da57d2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the 8308592-certexpiry branch September 19, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
3 participants