-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8308592: Framework for CA interoperability testing #14252
Conversation
👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into |
Webrevs
|
After this change, do all tests look exactly the same with only different URLs and CA alias names? If yes, can we just combine them into one test? |
There are few minor differences but most of them will look the same. I kept tests separate so we can treat each CA differently and run / problem list at granular level. I will try to reduce the duplicate code further. |
I suggest changing the title and description of the bug as the fix is more significant than updating a few expired certificates. |
test/jdk/security/infra/java/security/cert/CertPathValidator/certification/ActalisCA.java
Outdated
Show resolved
Hide resolved
...k/security/infra/java/security/cert/CertPathValidator/certification/ValidatePathWithURL.java
Show resolved
Hide resolved
...k/security/infra/java/security/cert/CertPathValidator/certification/ValidatePathWithURL.java
Show resolved
Hide resolved
...k/security/infra/java/security/cert/CertPathValidator/certification/ValidatePathWithURL.java
Outdated
Show resolved
Hide resolved
...k/security/infra/java/security/cert/CertPathValidator/certification/ValidatePathWithURL.java
Outdated
Show resolved
Hide resolved
test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java
Outdated
Show resolved
Hide resolved
test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java
Outdated
Show resolved
Hide resolved
test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java
Show resolved
Hide resolved
@rhalade This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@rhalade This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@rhalade This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@rhalade This pull request is now open |
@@ -23,70 +23,13 @@ | |||
|
|||
/* | |||
* @test | |||
* @bug 8245654 8314960 | |||
* @bug 8245654 8256895 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests for Certigna Root CA
is moved to CAInterop
but Certigna
CA test will continue to use old framework as there are no test URLs.
This test is also update test for JDK-8256895 which was part of SSLCA.java test
/integrate |
Going to push as commit da57d2a.
Your commit was automatically rebased without conflicts. |
The new approach uses test URLs directly to verify interoperability with CA infrastructure. This would help us avoid having regular test fixes to update test artifacts as long as CAs keep test domains up to date.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14252/head:pull/14252
$ git checkout pull/14252
Update a local copy of the PR:
$ git checkout pull/14252
$ git pull https://git.openjdk.org/jdk.git pull/14252/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14252
View PR using the GUI difftool:
$ git pr show -t 14252
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14252.diff
Webrev
Link to Webrev Comment