Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V #14256

Closed
wants to merge 2 commits into from

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Jun 1, 2023

JDK-8274242 propose to extend the x86 ISO-8859-1 encoding intrinsic to work
also for ASCII-compatible encodings, which helps speeding up various
CharsetEncoders. Implementing a similar intrinsic should be considered on
RISC-V as well.

The instruct log with -XX:+PrintOptoAssembly output looks like:

06e +   Encode ISO array R12, R11, R13 -> R10 # KILL R12, R11, R13, R7, V0-V3

Testing:

qemu w/ UseRVV:

  • Tier1 tests (release)
  • Tier2 tests (release)
  • Tier3 tests (release)
  • test/hotspot/jtreg/compiler/intrinsics/string/TestEncodeIntrinsics.java

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14256/head:pull/14256
$ git checkout pull/14256

Update a local copy of the PR:
$ git checkout pull/14256
$ git pull https://git.openjdk.org/jdk.git pull/14256/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14256

View PR using the GUI difftool:
$ git pr show -t 14256

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14256.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2023

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 1, 2023
@openjdk
Copy link

openjdk bot commented Jun 1, 2023

@DingliZhang The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 1, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 1, 2023

Webrevs

Copy link

@yhzhu20 yhzhu20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated change looks good. Thanks.

@openjdk
Copy link

openjdk bot commented Jun 1, 2023

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V

Reviewed-by: luhenry, yzhu, fyang, fjiang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • 62c935d: 8308978: regression with a deadlock involving FollowReferences
  • aff9cea: 8303530: Redefine JAXP Configuration File
  • 1bb037b: 8309329: com/sun/jdi/DeferredStepTest.java fails with virtual threads due to not waiting for threads to exit
  • a23bbea: 8309241: ClassForNameLeak fails intermittently as the class loader hasn't been unloaded
  • 931913f: 8309200: java/net/httpclient/ExecutorShutdown fails intermittently, if connection closed during upgrade
  • dc21e8a: 8296411: AArch64: Accelerated Poly1305 intrinsics
  • 59d9d9f: 8303215: Make thread stacks not use huge pages
  • cb1e5e3: 8309286: G1: Remove unused G1HeapRegionAttr::is_valid_gen
  • e8268d9: 8309210: Extend VM Operations hs_err logging
  • 7dbdad5: 8308892: Bad graph detected in build_loop_late after JDK-8305635
  • ... and 25 more: https://git.openjdk.org/jdk/compare/6c7225f819a729b1ef6f8b2769da4b50d879455d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@luhenry, @RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 1, 2023
Copy link
Member

@feilongjiang feilongjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@DingliZhang
Copy link
Member Author

@luhenry @yhzhu20 @RealFYang @feilongjiang Thanks for the review!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 3, 2023
@openjdk
Copy link

openjdk bot commented Jun 3, 2023

@DingliZhang
Your change (at version a42fa50) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 3, 2023

Going to push as commit 61bb014.
Since your change was applied there have been 35 commits pushed to the master branch:

  • 62c935d: 8308978: regression with a deadlock involving FollowReferences
  • aff9cea: 8303530: Redefine JAXP Configuration File
  • 1bb037b: 8309329: com/sun/jdi/DeferredStepTest.java fails with virtual threads due to not waiting for threads to exit
  • a23bbea: 8309241: ClassForNameLeak fails intermittently as the class loader hasn't been unloaded
  • 931913f: 8309200: java/net/httpclient/ExecutorShutdown fails intermittently, if connection closed during upgrade
  • dc21e8a: 8296411: AArch64: Accelerated Poly1305 intrinsics
  • 59d9d9f: 8303215: Make thread stacks not use huge pages
  • cb1e5e3: 8309286: G1: Remove unused G1HeapRegionAttr::is_valid_gen
  • e8268d9: 8309210: Extend VM Operations hs_err logging
  • 7dbdad5: 8308892: Bad graph detected in build_loop_late after JDK-8305635
  • ... and 25 more: https://git.openjdk.org/jdk/compare/6c7225f819a729b1ef6f8b2769da4b50d879455d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 3, 2023
@openjdk openjdk bot closed this Jun 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 3, 2023
@openjdk
Copy link

openjdk bot commented Jun 3, 2023

@RealFYang @DingliZhang Pushed as commit 61bb014.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
5 participants