8281455: Change JVM options with small ranges from 64 to 32 bits, for gc_globals.hpp #14259

afshin-zafari · 2023-06-01T11:15:48Z

The uintx/intx options whose ranges are small enough are changed to uint/int, otherwise gcc complains
when -Wconversion is used in build.
Their uses in printf formats are changed accordingly.

Tests

Locally hotspot:tier1 tested on linux-x64
mach5 tiers 1-4 on Linux and Windows 64bits platforms passed.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8281455: Change JVM options with small ranges from 64 to 32 bits, for gc_globals.hpp (Enhancement - P4)

Reviewers

Thomas Schatzl (@tschatzl - Reviewer)
Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14259/head:pull/14259
$ git checkout pull/14259

Update a local copy of the PR:
$ git checkout pull/14259
$ git pull https://git.openjdk.org/jdk.git pull/14259/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14259

View PR using the GUI difftool:
$ git pr show -t 14259

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14259.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-06-01T11:17:25Z

👋 Welcome back azafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-06-01T11:18:54Z

@afshin-zafari The following label will be automatically applied to this pull request:

hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

tschatzl · 2023-06-02T07:38:56Z

Although it's a bit early to review, when I looked at this briefly, I believe also the uintx that have a juint_max upper range can be replaced with uint (and use the equivalent UINT_MAX as upper range, j-types should only be used with JNI code).

afshin-zafari · 2023-06-07T08:52:00Z

Although it's a bit early to review, when I looked at this briefly, I believe also the uintx that have a juint_max upper range can be replaced with uint (and use the equivalent UINT_MAX as upper range, j-types should only be used with JNI code).

Done.

mlbridge · 2023-06-07T08:57:07Z

Webrevs

offamitkumar · 2023-06-07T09:16:55Z

Wouldn't that be good to keep the alignment for \ symbol in gc_global.hpp file ?

tschatzl

More candidates:

ParGCArrayScanChunk
MarkStackSize(Max) (these should probably be a size_t)
VerifyArchivedFields
ScavengeALotInterval
FullGCALotInterval
FullGCALotStart
FullGCALotDummies
VerifyGCLevel
MaxTenuringThreshold
InitialTenuringThreshold
GCDrainStackTargetSize

Some of these aren't uintx->uint conversions, so feel free to ignore.

tschatzl · 2023-06-07T09:30:46Z

src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.cpp

@@ -349,7 +349,7 @@ void PSAdaptiveSizePolicy::compute_eden_space_size(
    log_debug(gc, ergo)(
          "PSAdaptiveSizePolicy::compute_eden_space_size: gc time limit"
          " gc_cost: %f "
-          " GCTimeLimit: " UINTX_FORMAT,
+          " GCTimeLimit: " UINT32_FORMAT,


We use %u as format specifiers for uint.

%u is used.

tschatzl · 2023-06-07T09:31:57Z

src/hotspot/share/gc/shared/gcOverheadChecker.cpp

@@ -91,11 +91,11 @@ void GCOverheadChecker::check_gc_overhead_limit(GCOverheadTester* time_overhead,

  if (UseGCOverheadLimit) {
    if (gc_overhead_limit_exceeded()) {
-      log_trace(gc, ergo)("GC is exceeding overhead limit of " UINTX_FORMAT "%%", GCTimeLimit);
+      log_trace(gc, ergo)("GC is exceeding overhead limit of %d%%", GCTimeLimit);


Not sure why this place uses %d as format specifier compared to the UINT32_FORMAT the previous places did. Use %u ;)

%u is used.

tschatzl · 2023-06-07T09:32:15Z

src/hotspot/share/gc/shared/gc_globals.hpp

@@ -166,7 +166,7 @@
          "A System.gc() request invokes a concurrent collection; "         \
          "(effective only when using concurrent collectors)")              \
                                                                            \
-  product(uintx, GCLockerEdenExpansionPercent, 5,                           \
+  product(uint, GCLockerEdenExpansionPercent, 5,                           \


The \ needs to be aligned back.

tschatzl · 2023-06-07T09:34:19Z

src/hotspot/share/utilities/globalDefinitions.hpp

 // Table of values:
 //      sizeof intx         4               8
 // min_intx             0x80000000      0x8000000000000000
 // max_intx             0x7FFFFFFF      0x7FFFFFFFFFFFFFFF
 // max_uintx            0xFFFFFFFF      0xFFFFFFFFFFFFFFFF

 typedef unsigned int uint;   NEEDS_CLEANUP
+const uint  max_uint  = (uint)-1;


The change should use the existing UINT_MAX instead of adding a new constant. Instead of a cast of -1, one should also use ~0 to get all-ones.

UINT_MAX is used. New definition of max_uint is removed.

afshin-zafari

Suggested changes in Comments are applied including the 'more candidates'.

kimbarrett · 2023-06-07T15:06:54Z

src/hotspot/share/gc/g1/g1Arguments.cpp

@@ -229,7 +229,7 @@ void G1Arguments::initialize() {

  // By default do not let the target stack size to be more than 1/4 of the entries
  if (FLAG_IS_DEFAULT(GCDrainStackTargetSize)) {
-    FLAG_SET_ERGO(GCDrainStackTargetSize, MIN2(GCDrainStackTargetSize, (uintx)TASKQUEUE_SIZE / 4));
+    FLAG_SET_ERGO(GCDrainStackTargetSize, MIN2(GCDrainStackTargetSize, (uint)TASKQUEUE_SIZE / 4));


TASKQUEUE_SIZE should be a constant of type size_t rather than a macro. GCDrainStackTargetSize should be of type size_t. Then we don't need any casts here. But some uses may need cleaning up, either to remove casts or to adjust surrounding types. I suggest this be split out as a separate RFE to avoid cluttering the simplicity of this PR.

The change is applied and some cleanup made. Maybe no need to a new RFE, if you agree.

kimbarrett · 2023-06-07T15:13:07Z

src/hotspot/share/gc/parallel/jvmFlagConstraintsParallel.cpp

@@ -47,7 +47,7 @@ JVMFlag::Error InitialTenuringThresholdConstraintFuncParallel(uintx value, bool
  if (UseParallelGC && (value > MaxTenuringThreshold)) {
      JVMFlag::printError(verbose,
                          "InitialTenuringThreshold (" UINTX_FORMAT ") must be "
-                          "less than or equal to MaxTenuringThreshold (" UINTX_FORMAT ")\n",
+                          "less than or equal to MaxTenuringThreshold (%u)\n",


(github UI won't let me attach comment to the function signature)
The type of the value parameter should be changed in conjunction with the type change for the option,
both here and in jvmFlagConstraintsParallel.hpp. Similarly for MaxTenuringThresholdXXX below.

kimbarrett · 2023-06-07T15:15:24Z

src/hotspot/share/gc/parallel/psScavenge.cpp

@@ -553,7 +553,7 @@ bool PSScavenge::invoke_no_policy() {
                                                           _tenuring_threshold,
                                                           survivor_limit);

-       log_debug(gc, age)("Desired survivor size " SIZE_FORMAT " bytes, new threshold %u (max threshold " UINTX_FORMAT ")",
+       log_debug(gc, age)("Desired survivor size " SIZE_FORMAT " bytes, new threshold %u (max threshold %u)",


Consider also, instead of SIZE_FORMAT we can use "%zu".

%zu is used instead.

kimbarrett · 2023-06-07T15:15:56Z

src/hotspot/share/gc/shared/ageTable.cpp

@@ -99,7 +99,7 @@ uint AgeTable::compute_tenuring_threshold(size_t desired_survivor_size) {
  }


-  log_debug(gc, age)("Desired survivor size " SIZE_FORMAT " bytes, new threshold " UINTX_FORMAT " (max threshold " UINTX_FORMAT ")",
+  log_debug(gc, age)("Desired survivor size " SIZE_FORMAT " bytes, new threshold " UINTX_FORMAT " (max threshold %u)",


Consider also, instead of SIZE_FORMAT we can use "%zu".

%zu is used.

kimbarrett · 2023-06-07T15:18:19Z

src/hotspot/share/utilities/globalDefinitions.hpp

@@ -431,6 +431,7 @@ const intx  min_intx  = (intx)1 << (sizeof(intx)*BitsPerByte-1);
 const intx  max_intx  = (uintx)min_intx - 1;
 const uintx max_uintx = (uintx)-1;

+


stray blank line insertion?

kimbarrett · 2023-06-07T15:18:53Z

src/hotspot/share/utilities/globalDefinitions.hpp

@@ -439,7 +440,6 @@ const uintx max_uintx = (uintx)-1;

 typedef unsigned int uint;   NEEDS_CLEANUP


Unrelated, but I wonder why this "NEEDS_CLEANUP"?

Maybe, it is because the uint is already defined within the guarded lines 149-154:

#ifdef __USE_MISC /* Old compatibility names for C types. */ typedef unsigned long int ulong; typedef unsigned short int ushort; typedef unsigned int uint; #endif

I'm not seeing such a block? Neither in the current version nor in several recent versions. And I didn't
find __USE_MISC anywhere in the JDK. I did find what it's for and where it's supposed to come from:
https://stackoverflow.com/questions/10231885/what-is-use-misc-macro-used-for

I was curious and found it in /usr/include/x86_64-linux-gnu/sys/types.h on ubuntu. I guess it needs cleanup because it might not be defined with USE_MISC? There are too many int type names to choose from for int. Why does it say "Old compatibility names for C types."? Should we even be using uint ? I don't see it in https://en.cppreference.com/w/cpp/language/types - should we prefer "unsigned"?

This NEEDS_CLEANUP block shouldn't be part of this change.

kimbarrett · 2023-06-07T15:36:10Z

There are a lot of uses of the options that have casts, many of which ought to be removable with this change.
Some of those might pull more tangled strings, but it would be nice if there was a plan to look at those too.

afshin-zafari · 2023-06-08T12:14:55Z

There are a lot of uses of the options that have casts, many of which ought to be removable with this change. Some of those might pull more tangled strings, but it would be nice if there was a plan to look at those too.

During this change, I changed all the cases that I found them to be changed. Would you please, give some examples or some 'search criteria' that I can use to find the cases. Then, I will do them here in this PR or create a new RFE for them. Thanks.

afshin-zafari

The review comments are applied as stated.
The type of GCDrainStackTargetSize is changed and corresponding casts are also modified. Not so many changes were they. They can be excluded from this PR if needed.

coleenp

This looks like a good change to me to avoid Wconversion warnings for mis-sized argument values but I'll leave it up to the GC experts.

coleenp · 2023-06-08T12:24:11Z

src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.cpp

@@ -526,7 +526,7 @@ void PSAdaptiveSizePolicy::compute_old_gen_free_space(
    log_debug(gc, ergo)(
          "PSAdaptiveSizePolicy::compute_old_gen_free_space: gc time limit"
          " gc_cost: %f "
-          " GCTimeLimit: " UINTX_FORMAT,
+          " GCTimeLimit: " UINT32_FORMAT,


Should this be %u also?

kimbarrett · 2023-06-09T08:30:39Z

src/hotspot/share/gc/shared/gcOverheadChecker.cpp

      reset_gc_overhead_limit_count();
    } else if (print_gc_overhead_limit_would_be_exceeded) {
      assert(_gc_overhead_limit_count > 0, "Should not be printing");
-      log_trace(gc, ergo)("GC would exceed overhead limit of " UINTX_FORMAT "%% %d consecutive time(s)",
+      log_trace(gc, ergo)("GC would exceed overhead limit of %u %% %d consecutive time(s)",


An extra space has been added before "%%"; please remove.

kimbarrett · 2023-06-09T08:44:38Z

src/hotspot/share/utilities/globalDefinitions.hpp

@@ -439,7 +440,6 @@ const uintx max_uintx = (uintx)-1;

 typedef unsigned int uint;   NEEDS_CLEANUP


I'm not seeing such a block? Neither in the current version nor in several recent versions. And I didn't
find __USE_MISC anywhere in the JDK. I did find what it's for and where it's supposed to come from:
https://stackoverflow.com/questions/10231885/what-is-use-misc-macro-used-for

kimbarrett · 2023-06-09T08:54:50Z

src/hotspot/share/gc/g1/g1ConcurrentMark.cpp

@@ -2308,7 +2308,7 @@ void G1CMTask::drain_local_queue(bool partially) {
  // of things to do) or totally (at the very end).
  size_t target_size;
  if (partially) {
-    target_size = MIN2((size_t)_task_queue->max_elems()/3, (size_t)GCDrainStackTargetSize);
+    target_size = MIN2((size_t)_task_queue->max_elems()/3, GCDrainStackTargetSize);


I was hoping max_elems() wouldn't need a cast. Fixing that seems like it might be one of those long
and more complicated threads I was referring to earlier.

The max_elems() return uint and the cast is needed.

kimbarrett · 2023-06-09T09:01:08Z

src/hotspot/share/gc/shared/gc_globals.hpp

@@ -212,12 +212,12 @@
  /* where does the range max value of (max_jint - 1) come from? */         \
  product(size_t, MarkStackSizeMax, NOT_LP64(4*M) LP64_ONLY(512*M),         \
          "Maximum size of marking stack")                                  \
-          range(1, (max_jint - 1))                                          \
+          range(1, (SIZE_MAX - 1))                                          \


This is a large increase in the max size. Not at all sure it's appropriate. Similarly for MarkStackSize below.

kimbarrett · 2023-06-09T09:02:56Z

src/hotspot/share/gc/shared/gc_globals.hpp

          "Number of entries we will try to leave on the stack "            \
          "during parallel gc")                                             \
-          range(0, max_juint)                                               \
+          range(0, SIZE_MAX)                                                \


This is a large increase in the max on 64bit platforms.

Yes, you should revert the change from max_juint to SIZE_MAX. Is the change to size_t a cleanup to remove a cast?

Reverted back to original.

kimbarrett · 2023-06-09T09:06:21Z

There are a lot of uses of the options that have casts, many of which ought to be removable with this change. Some of those might pull more tangled strings, but it would be nice if there was a plan to look at those too.

During this change, I changed all the cases that I found them to be changed. Would you please, give some examples or some 'search criteria' that I can use to find the cases. Then, I will do them here in this PR or create a new RFE for them.

I spotted some when looking earlier, but haven't re-found any of them.

coleenp

I have a few comments. Narrowing the types of these arguments was to prevent Wconversion warnings where they're used and then later narrowed to 32 bit ints. From my sampling of some of the arguments changed, there were no casts, which was the problem. Some of these (sample GCTimeLimit) are promoted back up to uintx but having the field be the narrowest representation allows the code to use it without an implicit conversion to a narrower int type. So I think this is a good step for cleaning up the int types.

coleenp · 2023-06-09T14:11:49Z

src/hotspot/share/gc/shared/gc_globals.hpp

          "How much buffer to keep for pause time")                         \
-          range(0, max_juint)                                               \
+          range(0, UINT_MAX)                                                \


Why did you change from max_juint -> UINT_MAX ? max_juint should have compile without integer size mismatch.

Or, not in this change, but should we prefer UINT_MAX (found in /usr/include/limits.h) to our globalDefinitions.hpp definitions?

Now I see Thomas's comments about this. I guess changing a couple at a time would be ok.

coleenp · 2023-06-09T14:13:20Z

src/hotspot/share/gc/shared/gc_globals.hpp

          "Number of entries we will try to leave on the stack "            \
          "during parallel gc")                                             \
-          range(0, max_juint)                                               \
+          range(0, SIZE_MAX)                                                \


Yes, you should revert the change from max_juint to SIZE_MAX. Is the change to size_t a cleanup to remove a cast?

coleenp · 2023-06-09T14:30:00Z

src/hotspot/share/utilities/globalDefinitions.hpp

@@ -439,7 +440,6 @@ const uintx max_uintx = (uintx)-1;

 typedef unsigned int uint;   NEEDS_CLEANUP


I was curious and found it in /usr/include/x86_64-linux-gnu/sys/types.h on ubuntu. I guess it needs cleanup because it might not be defined with USE_MISC? There are too many int type names to choose from for int. Why does it say "Old compatibility names for C types."? Should we even be using uint ? I don't see it in https://en.cppreference.com/w/cpp/language/types - should we prefer "unsigned"?

coleenp · 2023-06-09T14:46:57Z

/label add hotspot-runtime

openjdk · 2023-06-09T14:47:51Z

@coleenp
The hotspot-runtime label was successfully added.

tschatzl

Lgtm, it's a step forward to cleaning up the gc_globals.hpp types/ranges.

openjdk · 2023-06-27T13:57:22Z

@afshin-zafari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281455: Change JVM options with small ranges from 64 to 32 bits, for gc_globals.hpp

Reviewed-by: tschatzl, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 461 new commits pushed to the master branch:

58bb655: 8222329: Readable read(CharBuffer) does not specify that 0 is returned when there is no remaining space in buffer
05e9c41: 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests
1587836: 8310425: [JVMCI] compiler/runtime/TestConstantDynamic: lookupConstant returned an object of incorrect type: null
73d7aa1: 8301489: C1: ShortLoopOptimizer might lift instructions before their inputs
990e3a7: 8308899: Introduce Classfile context and improve Classfile options
79c056e: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen
45b581b: 8309583: AArch64: Optimize firstTrue() when amount of elements < 8
87e6fab: 8310873: Re-enable locked_create_entry symbol check in runtime/NMT/CheckForProperDetailStackTrace.java for RISC-V
39fa4e6: 8310489: New test runtime/ClassInitErrors/TestStackOverflowDuringInit.java failed
46add3f: 8310909: java.io.InvalidObjectException has redundant @since tag
... and 451 more: https://git.openjdk.org/jdk/compare/4f096eb7c9066e5127d9ab8c1c893e991a23d316...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

coleenp

This looks good and definitely a step forward.

afshin-zafari · 2023-06-27T15:52:49Z

Thank you Coleen, Kim, Thomas and Amit for your comments and reviewing this PR.
/integrate

openjdk · 2023-06-27T15:54:57Z

Going to push as commit 7ce967a.
Since your change was applied there have been 462 commits pushed to the master branch:

f6133ed: 8310890: Normalize identifier names
58bb655: 8222329: Readable read(CharBuffer) does not specify that 0 is returned when there is no remaining space in buffer
05e9c41: 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests
1587836: 8310425: [JVMCI] compiler/runtime/TestConstantDynamic: lookupConstant returned an object of incorrect type: null
73d7aa1: 8301489: C1: ShortLoopOptimizer might lift instructions before their inputs
990e3a7: 8308899: Introduce Classfile context and improve Classfile options
79c056e: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen
45b581b: 8309583: AArch64: Optimize firstTrue() when amount of elements < 8
87e6fab: 8310873: Re-enable locked_create_entry symbol check in runtime/NMT/CheckForProperDetailStackTrace.java for RISC-V
39fa4e6: 8310489: New test runtime/ClassInitErrors/TestStackOverflowDuringInit.java failed
... and 452 more: https://git.openjdk.org/jdk/compare/4f096eb7c9066e5127d9ab8c1c893e991a23d316...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-06-27T15:55:12Z

@afshin-zafari Pushed as commit 7ce967a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

afshin-zafari added 2 commits May 31, 2023 10:39

before rebase on master

656fa73

JVM options limited to GC ones.

5b383b5

openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 1, 2023

afshin-zafari added 3 commits June 5, 2023 15:17

some more changes where juint were upperbounds.

653424d

defined max_uint.

1851e58

move max_uint definition after uint def.

9a489ae

afshin-zafari marked this pull request as ready for review June 7, 2023 08:52

openjdk bot added the rfr Pull request is ready for review label Jun 7, 2023

tschatzl suggested changes Jun 7, 2023

View reviewed changes

some more intx to int conversions.

b0b1501

afshin-zafari commented Jun 7, 2023

View reviewed changes

kimbarrett suggested changes Jun 7, 2023

View reviewed changes

review comments applied

97577d9

afshin-zafari commented Jun 8, 2023

View reviewed changes

coleenp reviewed Jun 8, 2023

View reviewed changes

kimbarrett suggested changes Jun 9, 2023

View reviewed changes

coleenp reviewed Jun 9, 2023

View reviewed changes

openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jun 9, 2023

review comments applied.

cbe66ac

tschatzl approved these changes Jun 27, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 27, 2023

coleenp approved these changes Jun 27, 2023

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jun 27, 2023

openjdk bot closed this Jun 27, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2023

		@@ -431,6 +431,7 @@ const intx min_intx = (intx)1 << (sizeof(intx)*BitsPerByte-1);
		const intx max_intx = (uintx)min_intx - 1;
		const uintx max_uintx = (uintx)-1;

		@@ -439,7 +440,6 @@ const uintx max_uintx = (uintx)-1;

		typedef unsigned int uint; NEEDS_CLEANUP

8281455: Change JVM options with small ranges from 64 to 32 bits, for gc_globals.hpp #14259

8281455: Change JVM options with small ranges from 64 to 32 bits, for gc_globals.hpp #14259

Conversation

afshin-zafari commented Jun 1, 2023 • edited by openjdk bot Loading

Tests

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Jun 1, 2023

openjdk bot commented Jun 1, 2023

tschatzl commented Jun 2, 2023

afshin-zafari commented Jun 7, 2023

mlbridge bot commented Jun 7, 2023 • edited Loading

Webrevs

offamitkumar commented Jun 7, 2023

tschatzl left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afshin-zafari left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kimbarrett commented Jun 7, 2023

afshin-zafari commented Jun 8, 2023

afshin-zafari left a comment

Choose a reason for hiding this comment

coleenp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kimbarrett commented Jun 9, 2023

coleenp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coleenp commented Jun 9, 2023

openjdk bot commented Jun 9, 2023

tschatzl left a comment

Choose a reason for hiding this comment

openjdk bot commented Jun 27, 2023 • edited Loading

coleenp left a comment

Choose a reason for hiding this comment

afshin-zafari commented Jun 27, 2023

openjdk bot commented Jun 27, 2023

openjdk bot commented Jun 27, 2023

afshin-zafari commented Jun 1, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Jun 7, 2023 •

edited

Loading

tschatzl left a comment •

edited

Loading

openjdk bot commented Jun 27, 2023 •

edited

Loading